541283 - Persona installation broken for Thunderbird 3.0 + personas 1.5

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect, P1)

Description

[Ryan Doherty (:rdoherty)]

STR:
Thunderbird 3.0.1
Personas 1.5.1

Tools => Personas => New & Featured => 41xxx more from new and featured
Mouseover thumbnail, 'apply' is missing
Click on thumbnail, orange button says 'get personas'

I never thought to check for Thunderbird in the detection for personas support, need to figure out what's different in Thunderbird.

Comment 1

[Ryan Doherty (:rdoherty)]

From comments in the google group, it appears that it was working in Personas 1.4 or 1.5. Myk: did anything change with Persona detection? (CheckPersonas event)

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: differences between 1.5 and 1.5.1

I can confirm that it works with 1.5 but not with 1.5.1.  But I don't see anything in this complete set of changes between those two versions that would account for the difference.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Erm, actually I do see the problem.  It's a regression from the fix for bug 535815.  The Error Console shows the error:

Error: gBrowser is not defined
Source File: chrome://personas/content/personas.js
Line: 281

That's because the fix assumes the presence of gBrowser when adding the TabSelect event listener on line 281 of personas.js, but that global variable doesn't exist in Thunderbird.

      gBrowser.tabContainer.addEventListener("TabSelect", this, false);

I expect there's a Thunderbird equivalent, although I don't know what it is.  cc:ing standard8, who can probably tell us.

Comment 4

[Mark Banner (:standard8)]

What are you trying to do with TabSelect? Not quite sure what the intention is there.

Anyway, assuming you're wanting to listen for tab selection changes, then take a look at:

http://mxr.mozilla.org/comm-central/source/mail/base/content/tabmail.xml#222

So you probably want to use something like document.getElementById("tabmail").registerTabMonitor(...);

Comment 5

[Jose E. Bolanos]

Unfortunately this bug was introduced when we fixed bug 535815. The code must be changed to support Thunderbird.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> Unfortunately this bug was introduced when we fixed bug 535815. The code must
> be changed to support Thunderbird.

Ok, so if you just want to reset on switching tab, then using the tab monitor like I mentioned in comment 4 should do exactly what you want.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

This is actually a Personas extension bug, so moving it to the right product/component.  Also tentatively setting priority/severity to P1, as I think it's very important to fix this regression in 1.5.1 (and spin a 1.5.2 release to get it out to users), although Ryan/Nick are in charge of triage/prioritization these days and should make the final call.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Oops, I didn't mean to reset the assignee.

Comment 9

[Jose E. Bolanos]

Fixed in changeset: http://hg.mozilla.org/labs/personas/rev/6cf263d5649c

Please verify. Thanks.

Comment 10

[Ryan Doherty (:rdoherty)]

Marking as 1.5 for 1.5.2 release.

Comment 11

[Carsten Book [:Tomcat]]

verified fixed in 1.5.2 personas plus candidate and thunderbird 3.0.3 !