Closed
Bug 541657
Opened 13 years ago
Closed 13 years ago
Port |Bug 540038 - add warning if configure or config.status are out of date| to comm-central
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1b1
People
(Reporter: sgautherie, Assigned: Callek)
References
Details
Attachments
(1 file)
1.08 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
Callek, could you do that one? I'm not very confident with it. Ted, while there, I wonder what the "all" target is: Could it be removed on m-c? Should it be added to c-c?
Flags: in-testsuite-
Assignee | ||
Comment 1•13 years ago
|
||
This does 2 things: * Adds an |all| target that we just forward to m-c (we do nothing with it here, I can pull it back out if you want) * Just copies the code from Bug 540038.
![]() |
||
Comment 2•13 years ago
|
||
Comment on attachment 423199 [details] [diff] [review] v1 -- just copy it Sounds good to me, even if the diff looked strange at first until I realized I was thinking differently than the diff tool ;-)
Attachment #423199 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Pushed as http://hg.mozilla.org/comm-central/rev/142e1e5b4f0b
Assignee | ||
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•13 years ago
|
Target Milestone: --- → Thunderbird 3.1b1
Reporter | ||
Updated•13 years ago
|
status-thunderbird3.0:
--- → ?
Comment 4•13 years ago
|
||
Re status-thunderbird3.0: Not sure I really care either way about this. It seems to be a build config issue that afaik no-one has ever hit and the build system should re-generate out of date configure anyway... or is there some other weird case? Either way, this doesn't feel enough to set "wanted", but "wontfix" is probably not appropriate either, so I'll just go for cancelling the flag.
status-thunderbird3.0:
? → ---
Reporter | ||
Comment 5•13 years ago
|
||
(In reply to comment #4) I'll let it be for now. I'll ask again if bug 540038 eventually makes it to m-1.9.1.
You need to log in
before you can comment on or make changes to this bug.
Description
•