541864 - tab bar is 1px larger when non-focused tabs have close buttons

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Will Roberts [:bws42]]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20100124 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20100124 Minefield/3.7a1pre

If you go from having 1 tab to 2 tabs the tab bar grows by 1 pixel. If you reach the number of tabs that will cause the close button to be hidden it will shrink by 1 pixel so that it is the same size as when you have a single tab.

Tested with compiz and metacity. I don't know when/if this regressed, but it is present in the 20090402 m-c nightly.

Reproducible: Always

Comment 1

[Will Roberts [:bws42]]

Attachment: single tab

Comment 2

[Will Roberts [:bws42]]

Attachment: two tabs

Comment 3

[Will Roberts [:bws42]]

Attachment: multiple tabs without close

Comment 4

[Tyler Downer [He/Him]]

WFM with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20100124 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20100124045447. maybe linux only though. Can you re-test in safe mode?
http://support.mozilla.com/en-US/kb/Safe+Mode

Comment 5

[Will Roberts [:bws42]]

I never saw it on Windows either. It happens even in safe-mode or with a new profile.

Comment 7

[Will Roberts [:bws42]]

I no longer see this on the Trunk using the same configuration I originally reported with. I believe it was fixed by the landing of bug 347930 though that may have been unintentional, because with the sidebar open if the focused tab is above the sidebar the gradient from the tab paints the top row of pixels of the sidebar (see attached image).

If you hover over the X of the sidebar the sidebar repaints the area around the button (can't capture via screenshot), then if you hover over the X of the tab the pixels get changed to the tab gradient.

Comment 8

[Will Roberts [:bws42]]

Attachment: tab gradient on top pixels of sidebar

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> Created an attachment (id=433577) [details]
> tab gradient on top pixels of sidebar

That's bug 546178, I think.

Comment 10

[Will Roberts [:bws42]]

Actually I still see this.

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/072e8c41a450

Comment 13

[Will Roberts [:bws42]]

Thanks, verified fixed in the nightly.