54218 - outdent and indent doesn't work properly.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Nasiruddin M.S]

Build id :2000090720
platform  : solaris2.8(intel)

(1) open composer in netscape communicator.
(2) type some text, move it to right using 'indent' icon. The text moves to the
right.
(3) press enter. type some text. Now try to move the text (only last line
text)to the left using outdent. The text doesn't move to the left.

This bug is simillar to Bug id 8436 and 38253. Though those bugs are fixed, it
is not working on the platform specified above.

Comment 1

[anthonyd]

setting to future.

anthonyd

Comment 2

[rubydoo123]

asked Sujay to please test on solaris to see the extent of the issue. reassign
to cmanske

Comment 3

[sujay]

worksforme on windows....I don't ahve a Solaris build.

Comment 4

[Charles Manske]

Akkana - can you test on Solaris?

Comment 5

[Akkana Peck]

No, I don't have a solaris build.  I've tried to get one, but we no longer seem
to have a machine capable of building mozilla.

Comment 6

[Steve Parkinson]

I have another testcase which also demonstrates a bug with indent and outdent.

Select a paragraph.
Press the indent button twice.
Now try to return the paragrph to the original indentation - press the outdent
button twice

You can't, because after you press the outdent button once, it grays itself out.

In other words, you can only outdent a paragraph once.

Comment 7

[Charles Manske]

The problem occurs when testing if we can outdent, in
nsHTMLEditRules::GetIndentState().
The test nsHTMLEditUtils::IsBlockquote(curNode) returns false, probably because
of the <br>. The HTML described in the bug test is:
<blockquote> Some text on the first line, then press enter<br>
so this text is on a second line.
</blockquote>
The second line is a text child of the <br>, not <blockquote>, so it thinks
we can't outdent.
Joe: Should these tests climb up the parent chain to find list and blockquote
tags?

Comment 8

[Joe Francis]

moz 0.9

Comment 9

[Joe Francis]

moving a bunch of 0.9 bugs to 0.9.1

Comment 10

[Kathleen :Brade]

*** Bug 61270 has been marked as a duplicate of this bug. ***

Comment 11

[rubydoo123]

*** Bug 68280 has been marked as a duplicate of this bug. ***

Comment 12

[Raghu Sakleshpur]

Looks like the indent feature is grayed out on win NT platform. I tried this out
on mozilla nightly build: 2001041704. Updating the bug platform/OS category to
win NT

Comment 13

[rubydoo123]

*** Bug 57715 has been marked as a duplicate of this bug. ***

Comment 14

[Joe Francis]

attaching patch which will enable outdent correctly.  Note that outdent behavior
is still a bit odd, but at least you can get it to outdent in cases like the one
above.

Comment 15

[Joe Francis]

Attachment: patch for editor/base/nsHRMLEditRules.cpp

Comment 16

[Simon Fraser [no longer active]]

Typo:
+    // of selection endpoints.  We might have a bolckquote or list item 
r/sr=sfraser

Comment 17

[kinmoz]

r=[e-mail]

Comment 18

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers).  Can we keep this bug open or file another one for the
remaining issues. Thanks.

Comment 19

[Kathleen :Brade]

Asa, I'm not sure we should keep this bug open.  It might be easier to track 
remaining issues in new/separate bugs so it'll be easier to verify.

Comment 20

[Joe Francis]

fix checked in.  i will open new bug for remaining issues.

Comment 21

[sujay]

verified.

Comment 22

[sujay]

this is fixed, however we have another problem...see bug 17994