Closed
Bug 542272
Opened 15 years ago
Closed 15 years ago
Email add-on to a friend feature
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P1)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
RESOLVED
FIXED
5.7
People
(Reporter: osunick, Assigned: wenzel)
Details
Attachments
(8 files, 2 obsolete files)
Spec here: (needs design for hi-fi mocks)
http://docs.google.com/Doc?docid=0Ad7mAOXgEBZyZGRzNnZ3YjRfMjVmbWRyZnpyNA&hl=en
Reporter | ||
Updated•15 years ago
|
Priority: -- → P1
Target Milestone: --- → 5.7
Reporter | ||
Updated•15 years ago
|
Assignee: nobody → neilio
Comment 1•15 years ago
|
||
Here's the design for the flyout modal window - the interaction here is identical to the "share this" widget. Hitting cancel closes the modal.
After the user hits "send", a success message overlays the email this form, and then the modal disappears after 2-3 seconds - see email-this-success.png
Comment 2•15 years ago
|
||
Comment 3•15 years ago
|
||
Here's what the email recipient receives if they have HTML email enabled. If there is a custom message, the centre area that shows the add-on description is replaced by that.
Reporter | ||
Comment 4•15 years ago
|
||
Hi Neil,
Sorry to drop this on you but we've decided to combine the flyout modal into the share this widget- so "email this add-on" appears as an additional option. Adding complexity to this is that logged out users should see the option but get a note "Please log in to email this add-on" instead of the full UI of the widget. Can we get another rev?
Also, upon further reflection, we're dumping HTML email from the spec.
Comment 5•15 years ago
|
||
Comment 6•15 years ago
|
||
Comment 7•15 years ago
|
||
Comment 8•15 years ago
|
||
Here's the flow for the share this widget, which points out the interaction flow and various states.
Comment 9•15 years ago
|
||
Rejigged email this panel with resized text field to accommodate error messaging.
Attachment #424703 -
Attachment is obsolete: true
Reporter | ||
Comment 10•15 years ago
|
||
Perfect. Thank you.
Reporter | ||
Comment 11•15 years ago
|
||
reassigning to clouserw for assignment.
Assignee: neilio → clouserw
Updated•15 years ago
|
Assignee: clouserw → fwenzel
Assignee | ||
Comment 12•15 years ago
|
||
Not sure why we needed to introduce sub-features like ajax login for this, but here you go.
It's huge, but hopefully easy to grasp. Each of the two emails exists as HTML and non-HTML variant.
Attachment #426256 -
Flags: review?(clouserw)
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Updated•15 years ago
|
Attachment #426256 -
Flags: review?(clouserw) → review-
Comment 13•15 years ago
|
||
Comment on attachment 426256 [details] [diff] [review]
Patch, rev. 1
You're right, the mockups do introduce the ajax log-in which is not in the spec and which shouldn't be there. Additionally, we're not doing the HTML emails due to image blocking in every major email client. Sorry for not catching these sooner. For everyone: Mockups should not deviate from the spec without cited reasoning so please say something if you notice it. In this case it slipped through.
Due to the number of changes in this patch please upload a new patch without HTML email and without the ajax log-in. If a user is logged out and clicks on the email link it can just be a link that says "Log in to email this add-on to a friend"
Thanks
Comment 14•15 years ago
|
||
I'm not exactly sure how we'd handle this without the ajax login, if you want everything within the widget itself. If we want to jump to a completely separate page, it'd work, but not integrated into the widget itself.
Comment 15•15 years ago
|
||
Nick, can you clarify how you want this to work? If the user is logged in, the email can happen within the widget, but I don't see how we'd bring the user back to the widget post-log in without making the process really confusing.
Assignee | ||
Comment 16•15 years ago
|
||
if we make it a login link, it'll take you to the login page, and transport you back to the addon page, where you would need to click the "share this" link again.
I'm also missing where the HTML format was dropped here or in the spec, but I can remove that. clouserw is right that it will only be shown correctly on request, and gmail won't show backgrounds etc at all.
Assignee | ||
Comment 17•15 years ago
|
||
Over to Nick. Please throw it back when the specs are clear.
Assignee: fwenzel → nnguyen
Status: ASSIGNED → NEW
Assignee | ||
Comment 18•15 years ago
|
||
All right, talked to clouserw. Will remove HTML mail and AJAX login, then submit a new patch.
Assignee: nnguyen → fwenzel
Status: NEW → ASSIGNED
Assignee | ||
Comment 19•15 years ago
|
||
This is the patch with half the fun stuff removed.
Attachment #426256 -
Attachment is obsolete: true
Attachment #426328 -
Flags: review?(clouserw)
Comment 20•15 years ago
|
||
Comment on attachment 426328 [details] [diff] [review]
Patch, rev. 2
This is awesome, thanks.
Attachment #426328 -
Flags: review?(clouserw) → review+
Assignee | ||
Comment 21•15 years ago
|
||
Reporter | ||
Comment 22•15 years ago
|
||
Hooray, no HTML email and AJAX login is correct. Once [z] is ready we'll put AJAX login back in, with a new bug.
Updated•15 years ago
|
Keywords: push-needed
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•