542464 - Dependency graphs cannot be displayed when bug summaries contain UTF8 characters

Status: RESOLVED FIXED

(Bugzilla :: Dependency Views, defect)

Description

[Werner Moser]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: bugzilla 3.4.4

We have upgraded from bugzilla 3.0 to 3.4.4 and now the dependency graph fails if a bug is involved which summary contains a german umlaut ("Show the summaries of all displayed bugs" needs to be activated, obviously).

/usr/bin/dot is used: dot - graphviz version 2.24.0 (20090616.2323)

this error is logged by the apache:


Reproducible: Always

Steps to Reproduce:
1. create a bug with a german umlaut in the summary
2. click on "graph"
3. activate "Show the summaries of all displayed bugs"
Actual Results:  
no graph is displayed, error in apache logfile.

Expected Results:  
graph to be displayed.

this is the second characterset problem in 3.4.4 with german umlauts that we found (see bug 541776) - are they related?

To exclude migration errors: I installed 3.4.4 from scratch, new database: the same error.

Comment 1

[Marc Schumann [:Wurblzap]]

Bug 287684 is older, so it's probably not a dupe, but I'd say it's related...

Comment 2

[Frédéric Buclin]

Just tried right now and I got:

showdependencygraph.cgi: Wide character in print at /var/www/html/bugzilla/showdependencygraph.cgi line 222.
Invalid 3-byte UTF8 found in input. Perhaps "-Gcharset=latin1" is needed?
showdependencygraph.cgi: Use of uninitialized value $default in concatenation (.) or string at /var/www/html/bugzilla/showdependencygraph.cgi line 83.

Not sure whether this is a single or multiple issue.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Same trick as all other places where wide characters are a problem. Tested, and this fixes the problem.

Comment 4

[A. Shimono [:himorin]]

For Japanese, this bug does not reproducible.
w/ or w/o this patch, test installations don't have this issue.

http://landfill.bug-ja.org/ja-304/showdependencygraph.cgi?id=1&showsummary=on&display=tree&rankdir=TB

Comment 5

[A. Shimono [:himorin]]

Finally, I could not reproduce this bug.
See our test server, url is the same as comment 4.
> http://landfill.bug-ja.org/ja-304/showdependencygraph.cgi?id=1&showsummary=on&display=tree&rankdir=TB

For me, it's not related on our code, but some perl module version.

Comment 6

[Vitaly Fedrushkov]

Looks like we need more data on platforms (and of course Perl versions) tested

Comment 7

[Frédéric Buclin]

Marc, ping?

Comment 8

[Max Kanat-Alexander]

Comment on attachment 425977 [details] [diff] [review]
patch, v1

Looks fine to me.

Comment 9

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified showdependencygraph.cgi
Committed revision 7051.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified showdependencygraph.cgi
Committed revision 7019.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.4/
modified showdependencygraph.cgi
Committed revision 6738.

Comment 10

[Marc Schumann [:Wurblzap]]

Thanks, this would've taken at least one more week for me.