Closed
Bug 542608
Opened 13 years ago
Closed 13 years ago
Audio but no video on flash sites with Flashblock installed
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(blocking2.0 alpha1+, blocking1.9.2 -, status1.9.2 .2-fixed, status1.9.1 unaffected)
VERIFIED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
blocking2.0 | --- | alpha1+ |
blocking1.9.2 | --- | - |
status1.9.2 | --- | .2-fixed |
status1.9.1 | --- | unaffected |
People
(Reporter: jmjjeffery, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: regression, verified1.9.2)
Attachments
(1 file)
2.65 KB,
patch
|
roc
:
review+
beltzner
:
approval1.9.2.2+
|
Details | Diff | Splinter Review |
Visit YouTube or MSNBC and view a video. There is audio, but no video. Reported here: http://forums.mozillazine.org/viewtopic.php?f=23&t=1719975 I saw at first the same shift in the video, or rather non-movement with scroll, then after turning off OOPP, and back on during testing I lost the video component. regression shows window: Works in cset: http://hg.mozilla.org/mozilla-central/rev/e436d3c5a4a6 01/25/10 09:19build Broken in cset: http://hg.mozilla.org/mozilla-central/rev/795803409745 Leaving https://bugzilla.mozilla.org/show_bug.cgi?id=521426 as the possible problem of losing the video.
Reporter | ||
Updated•13 years ago
|
Keywords: regression
Comment 1•13 years ago
|
||
bug 535295 maybe related?
Comment 2•13 years ago
|
||
Is this OOPP-only, or in-process plugins as well?
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to comment #2) > Is this OOPP-only, or in-process plugins as well? Does matter if OOPP is on or off, still no video, just audio.
Reporter | ||
Comment 5•13 years ago
|
||
Well, further testing reveals that the Flashblock addon is likely the problem. Tested with new profile and was working OK. Went back to my normal profile and video was not showing, only sound. Even though the site was allowed through Flashblock, there was no video until I 'disabled' the addon. So, don't know if something broke the in-line function of Flashblock, or what.. not a programmer. If something thinks this is not a Minefield issue, but rather an update is required in Flashblock, feel free to close as INVALID.
This is looks like bug 542447, which got duped to bug 542447. I'm not sure the duping was correct, so I'm waiting for bug 540604 to verify.
Gaah!!! Gotta proofread. This looks like bug 542447, which got duped to bug 542263. I'm not sure the duping was correct, so I'm waiting for bug 540604 to verify.
![]() |
||
Comment 9•13 years ago
|
||
Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e436d3c5a4a6&tochange=795803409745 Only one changeset: http://hg.mozilla.org/mozilla-central/rev/795803409745 Null-check the root pres context result. Unregister the plugin frame earlier, at Stop instead of Destroy time. b=521426 r=roc Bug 521426 (Crash [@ PL_DHashTableEnumerate] called from nsRootPresContext::GetPluginGeometryUpdates because nsPresContext::RootPresContext() can return non-nsRootPresContext object) With Flashblock actively blocking youtube, clicking on the flashblock placeholder allows the video to play normally. With youtube whitelisted the audio is heard but the video is not seen. The flashblock content XBL uses a DOM UIEvent to send a whitelist signal to chrome. The flashblock chrome code then checks the whitelist: checkLoadFlash : function (e) { if(!gFlashblockEnabled || Flashblock.checkWhitelist(e.target.location)) e.preventDefault(); e.stopPropagation(); }, So somehow the time taken to check the whitelist interferes with the timing and the video does not paint. If I use Stylish (or nsIStylesheetService) to change the style of the youtube embed @-moz-document domain(youtube.com) { #movie_player { display: block; } } The video reappears. It doesn't matter what I change the display: to I just need to toggle it and the flashplayer appears, the video becomes visible and restarts from the beginning. I would guess that toggling the display style causes a reflow and reinits the flashplayer.
Blocks: 521426
Assignee: nobody → matspal
Comment 10•13 years ago
|
||
This bug also causes youtube videos to scroll as the page is scrolled, instead of remaining fixed in place.
Comment 11•13 years ago
|
||
...but only if the site is not whitelisted in flashblock and a user presses the flashblock icon to start playback.
![]() |
||
Comment 12•13 years ago
|
||
Which doesn't make any sense, since once the flash object is re-inserted into the DOM flashblock is out of the picture.
Comment 13•13 years ago
|
||
I think that flashblock is important enough this needs to block 1.9.3alpha1.
blocking2.0: --- → alpha1
Assignee | ||
Comment 14•13 years ago
|
||
We need to always register the frame when there's a widget (balancing the condition for when we unregister), not just the first time when creating the widget. (Flashblock caused a re-instantiation of a stopped plugin using the existing frame/widget.)
Attachment #424024 -
Flags: review?(roc)
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Comment 15•13 years ago
|
||
Test builds: https://build.mozilla.org/tryserver-builds/mpalmgren@mozilla.com-542608-patch1/
Reporter | ||
Comment 16•13 years ago
|
||
(In reply to comment #15) > Test builds: > https://build.mozilla.org/tryserver-builds/mpalmgren@mozilla.com-542608-patch1/ All seems good here..just tested on several sites, with and without flashblock, and all appears normal.
Attachment #424024 -
Flags: review?(roc) → review+
Attachment #424024 -
Flags: approval1.9.2.1?
Why is this marked 1.9.2-unaffected? As far as I can tell it should affect 1.9.2. Thanks Mats! I guess we should be able to have a test here.
blocking1.9.2: --- → ?
![]() |
||
Comment 18•13 years ago
|
||
> Why is this marked 1.9.2-unaffected? Probably because bug 521426 hasn't landed on 1.9.2 yet. This should be marked the same way that bug is, imo.
Assignee | ||
Comment 19•13 years ago
|
||
Yes, my plan was to merge this fix with the 1.9.2 patch on bug 521426 and asking for approval on that, but this works too.
Assignee | ||
Comment 20•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8ad351bc774b
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Comment 21•13 years ago
|
||
Will wait another day or two to allow the regression fix to bake.
Reporter | ||
Comment 22•13 years ago
|
||
I can verify that this is fixed on m-c with the latest hourly: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20100128 Minefield/3.7a1pre ID:20100128145729 cset: http://hg.mozilla.org/mozilla-central/rev/8ad351bc774b
![]() |
||
Comment 23•13 years ago
|
||
<http://forums.mozillazine.org/viewtopic.php?p=8566275#p8566275> Users report issue with Flashblock is fixed in the latest hourly builds. Thanks guys for the quick response.
Updated•13 years ago
|
blocking1.9.2: ? → -
Comment 24•13 years ago
|
||
Comment on attachment 424024 [details] [diff] [review] Patch rev. 1 a1922=beltzner
Attachment #424024 -
Flags: approval1.9.2.2? → approval1.9.2.2+
Assignee | ||
Comment 25•13 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a32a618eb663 http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7723073d61b2
Comment 26•12 years ago
|
||
I can VERIFY FIXED with latest nightly on Win32 Vista.
Status: RESOLVED → VERIFIED
Comment 27•12 years ago
|
||
Running 1.9.2.0 here on XP, I cannot reproduce this issue using Flashblock 1.5.11.2. If I whitelist youtube and watch videos there, they will play fine (just as they do if I don't whitelist but select the flashblock button on the video when it shows up). Have we actually seen this problem in Firefox 3.6 at all?
Assignee | ||
Comment 28•12 years ago
|
||
Al, this bug was a regression fix for bug 521426 which never landed on 1.9.2 by itself. Both patches together on 1.9.2 (comment 25).
Comment 29•12 years ago
|
||
Thanks, Mats. Does this mean that there is no scenario to repro the bug on 1.9.2 since the original regression by itself?
Assignee | ||
Comment 30•12 years ago
|
||
Not with a nightly build, no.
Updated•12 years ago
|
Summary: Audio No Video on flash sites → Audio but no video on flash sites with Flashblock installed
Comment 31•12 years ago
|
||
I was able to reproduce this bug with an older Minefield build. A recent build on trunk doesn't show this problem. Even the candidate build 3 of Firefox 3.6.2 looks good. Marking as verified on 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2
Keywords: verified1.9.2
Assignee | ||
Updated•12 years ago
|
Flags: in-testsuite?
Updated•9 days ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•