542611 - Translation summary statistics are strange

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect, P3)

Description

[:gerard-majax]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.2) Gecko/20100115 Firefox/3.6
Build Identifier: 

Looking at the « Catégories » summary, we can see it reports 77% of translated strings, while everything has been translated for one or two week now.

Reproducible: Always

Steps to Reproduce:
1. Translate
2. Check
Actual Results:  
Currently, the statistic seems buggy.

Expected Results:  
If everything is translated, we should see a 100%.

Comment 1

[Wil Clouser [:clouserw]]

wenzel, can you double check this?  It might be the cron jobs not running, or it might be that we're counting blanks against the total percentage (or something else).  Thanks!

Comment 2

[:gerard-majax]

I should add that others statistics looks correct.

Comment 3

[:gerard-majax]

I updated Categories on AMO (not preview). Everything is translated, yet the measure went from 69 percent to 77 percent.

Comment 4

[Fred Wenzel [:wenzel]]

I am guessing it's because of the empty descriptions some of the categories have. I might need to write some code to catch these: If there's nothing to be translated, it should count it.

Comment 5

[:gerard-majax]

Hm, after working on the pages part, I'm wondering if there's some issues too.
Only one file remaining to be translated [https://preview.addons.mozilla.org/fr/localizers/pages?userlang=fr], and yet, the « pages » statistics says 85% done. Each previously translated file added 5%, so by the same logic, we'll be at 90% when everything is translated. It's not a cache issue.

Are there some missing pages in the list that are counted for pages statistics and that we missed ?

Comment 6

[:gerard-majax]

I tried some trick, as you can see on the preview : https://preview.addons.mozilla.org/fr/localizers/categories?userlang=fr

I added « N/A » for each empty description. By doing this, I went from 77% translated to 92%.

Comment 7

[Fred Wenzel [:wenzel]]

Thanks again, Alexandre. I found both problems that were causing this. First, we'll not count strings as untranslated anymore that are not in use in en-US either. Second, the localized image for the sandbox was not counted as a translated "page" even if it existed, that's fixed now as well.

Note that this won't show up publicly until the next release. On preview, however, I am guestimating the new maintenance tasks will run tomorrow (or does the gearman worker need to be restarted? hmm...).

r62254.