Port |Bug 454256 - --enable-static firefox builds should error in configure| to comm-central

RESOLVED FIXED in Future

Status

defect
--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sgautherie, Assigned: Callek)

Tracking

Trunk
Future
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

This will be wanted, but is not needed until at least one c-c app (can)  --enable-libxul.
Flags: in-testsuite-
well, its more a matter of "do we want to error in c-c or error in m-c configure".

We can set the confvars.sh value in any c-c app and still error in m-c configure without actually porting the error. In the end, as long as we have the libxul stuff in *our* configure, I do support this port.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attachment #430797 - Flags: review?(kairo)
Attachment #430797 - Flags: feedback?(sgautherie.bz)
Comment on attachment 430797 [details] [diff] [review]
just port it [checkin c#6]


This copy patch is correct, but we don't need it:
failing in m-c configure is enough.

If your purpose is to reduce
http://dev.seamonkey.at/?d=x&i=mozilla&m=c
asap, then I suggest to port |MOZ_STATIC_BUILD_UNSUPPORTED=0| with a reference to this bug (or just port nothing) for now, then make this bug depend on bug 394502 (or file a followup).
Attachment #430797 - Flags: feedback?(sgautherie.bz) → feedback-
Attachment #430797 - Flags: review?(kairo) → review+
Comment on attachment 430797 [details] [diff] [review]
just port it [checkin c#6]

Not that it is being used anywhere in comm-central yet - but once we do, I'd like us to error out as soon as possible in the process, so let's take it.
I can stand this one as somewhat useful,
yet that's the kind of "redundant" checks I'm removing (too) from c-c in the "configure cleanup" process :-/
Comment on attachment 430797 [details] [diff] [review]
just port it [checkin c#6]

http://hg.mozilla.org/comm-central/pushloghtml?fromchange=386d5b686699&tochange=a803df412b50
Attachment #430797 - Attachment description: just port it → just port it [checkin c#6]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.