Update Help on Popup Windows preferences

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Help Documentation
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

({fixed-seamonkey2.0.4})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.4

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 424486 [details] [diff] [review]
patch

While looking at bug 459578 I discovered that Help has not been updated for some of the latest changes to the Popup Windows preferences pane and the dialog that can be opened from there. Part of the changes were made in bug 441403.

@IanN: Bug 441403 comment 0, last sentence. ;-)
(Assignee)

Updated

7 years ago
Assignee: nobody → jh
Status: NEW → ASSIGNED
(Assignee)

Updated

7 years ago
Attachment #424486 - Attachment is patch: true
Attachment #424486 - Attachment mime type: application/octet-stream → text/plain
Attachment #424486 - Flags: review?(iann_bugzilla)

Comment 1

7 years ago
Comment on attachment 424486 [details] [diff] [review]
patch

>+++ b/suite/locales/en-US/chrome/common/help/cs_priv_prefs_popup.xhtml
>   <li><strong>Play a sound</strong>: If you want a sound to play each time
>-    the browser blocks a popup, select this option and type the location of the
>-    sound file.
>+    the browser blocks a popup, select this option and choose System beep
>+    or Custom sound file. For the latter you can either type the location of
>+    the sound file or browse for it.
As far as I am aware, you can only browse not type the location in the new pref window.
>     <ul>
>-      <li><strong>Select</strong>: Click this to choose a sound file instead of
>+      <li><strong>Browse</strong>: Click this to choose a sound file instead of
>         typing its location in the field.</li>
This needs correcting too.
Attachment #424486 - Flags: review?(iann_bugzilla) → review-
(Assignee)

Comment 2

7 years ago
Created attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]
Attachment #424486 - Attachment is obsolete: true
Attachment #424668 - Flags: review?(iann_bugzilla)

Updated

7 years ago
Attachment #424668 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 3

7 years ago
Comment on attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]

http://hg.mozilla.org/comm-central/rev/192025e17ba3
Attachment #424668 - Attachment description: patch v1a → patch v1a [Checkin: comment 3]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
(Assignee)

Comment 4

7 years ago
Comment on attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]

Requesting branch approval.

[KaiRo]	InvisibleSmiley: help changes are allowed, as long as the list of the help files stays the same
Attachment #424668 - Flags: approval-seamonkey2.0.4?
(Assignee)

Updated

7 years ago
Blocks: 423281

Updated

7 years ago
Attachment #424668 - Flags: approval-seamonkey2.0.4? → approval-seamonkey2.0.4+
(Assignee)

Comment 5

7 years ago
Comment on attachment 424668 [details] [diff] [review]
patch v1a [Checkin: comments 3 + 5]

http://hg.mozilla.org/releases/comm-1.9.1/rev/167ea8785ebb
Attachment #424668 - Attachment description: patch v1a [Checkin: comment 3] → patch v1a [Checkin: comments 3 + 5]
(Assignee)

Updated

7 years ago
Keywords: fixed-seamonkey2.0.4
You need to log in before you can comment on or make changes to this bug.