543504 - [dashboard][shipping] dashboard should support signoff=pending

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect, P3)

Description

[Axel Hecht [:Pike]]

We should have a param to the dashboard that let's us only see pending sign-offs, for a set of appversions.

I.e., status=pending&av=fx3.6&av=fx3.5&fennec1.0

That would make triage so much easier. For us and for other drivers.

Comment 1

[Staś Małolepszy :stas]

I started looking at it and have a patch that does what you' expect with /shipping/api/signoffs?av=fx3.5&status=pending. But, l10nstats still gives the full list of Shippings, not sure how to approach that. Pike, any thoughts?

Comment 2

[Staś Małolepszy :stas]

Attachment: Patch A.1

The simplest solution available: select the right facet option ("pending") if there's a "signoff" parameter in the query. 

It doesn't do any magic on the server side, which results in you getting the whole Exhibit dataset just to see a handful of pending signoffs. But, you can then unselect "pending" and see all builds without a reload.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 424772 [details] [diff] [review]
Patch A.1

r=me, with a nit, add a trailing ';' to options.push("signoff");

Comment 4

[Staś Małolepszy :stas]

Thanks.

http://hg.mozilla.org/l10n/django-site/rev/da470992b57e

Comment 5

[Staś Małolepszy :stas]

(In reply to comment #0)
> We should have a param to the dashboard that let's us only see pending
> sign-offs, for a set of appversions.
> 
> I.e., status=pending&av=fx3.6&av=fx3.5&fennec1.0

I just noticed that multiple appversions don't work in the current code. I have a patch almost ready, do you want me to finish it?

Comment 6

[Axel Hecht [:Pike]]

Mind moving that to a new bug?

I'd like to see what the patch looks like, as I have some ideas on it in my head, too.

Comment 7

[Staś Małolepszy :stas]

Filed bug 543940.