Closed Bug 543667 Opened 14 years ago Closed 13 years ago

Support trac URLs in the "See Also" field

Categories

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

3.4.4
enhancement

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: clouserw, Assigned: selsky)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Since the trend is to file a separate bug for each remote system (bug 532350, bug 533121) I'm filing this one for trac.  I attempted to add http://code.djangoproject.com/ticket/12725 as a "see also" field to one of the AMO bugs and failed with the message about needing a bugzilla URL.

Expected result:

URL is added, even if it doesn't update through some API.
In looking at the list of bugs, like this one or bug 532350 or bug 533121, I wonder if the best solution is to let any url reside in the see also field, because ultimately, we can't keep up with all of the possible bug tracking systems or the url patterns for each.
Well, no, for now we do want to keep it limited to some sort of specific system, because (a) then we can normalize the URLs so that we can eliminate duplicates and keep the system standard and (b) in the future there will indeed be remote API support for updating the other bug-tracker.
Priority: -- → P2
I agree, but the two are not necessarily exclusive.  We could enable any url and then allow Bugzilla to use it's data collection API if the url is recognized by Bugzilla to belong to a standardized, known project, like Bugzilla, Google Code, trac, etc.

If we did that, then for the moment, users could apply any url from any url tracking system that they choose, and later as the API is implemented, data harvesting can occur for select issue tracking systems.  Since, there are many issue tracking systems that are valid, we don't need an API to harvest data from all of them, just a few major ones which prevents a lot of overhead and code maintenance for Bugzilla, because a minor bug system might change where the bug title is and Bugzilla would have to support the old version and the new version.

Another thought, using bugzil.la in the See Also field would be very nice and efficient for BMO-specific bugs, but as Gerv notes in bug 532350, it will be almost a year before that ability could even start to be possible as 3.4 and 3.6 are not accepting enhancements.
Yeah, I understand what you're saying. From a software development perspective, my principles tell me that it's generally better to have a validated, controlled set of data than to have an unbounded set of data, and that the more focused we keep a feature, the more powerful and useful it can be.

I'm all in support of having support for Trac URLs in the core of Bugzilla, though, by the way. Mantis and Jira too, if anybody wants to write code for it.

I think the solution for bugzil.la is to allow hooking the validation code, which would convert that to a standard URL.
Attached patch Add support for Trac URLs (obsolete) — Splinter Review
Asking timello to review based on feedback in bug 558784.
Attachment #480953 - Flags: review?(timello)
Comment on attachment 480953 [details] [diff] [review]
Add support for Trac URLs

Now we have to use the new see also code. You
should create a Bugzilla/BugUrl/Trac.pm. Use the other bug trackers as example
how to implement it.
Attachment #480953 - Flags: review?(timello) → review-
Attachment #480953 - Attachment is obsolete: true
Attachment #499229 - Flags: review?(timello)
Assignee: create-and-change → selsky
Status: NEW → ASSIGNED
Comment on attachment 499229 [details] [diff] [review]
Add support for detecting Trac URLs, v2

It looks good for me.
Attachment #499229 - Flags: review?(timello) → review+
Flags: approval?
Very cool! :-)
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 4.2
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                      
modified Bugzilla/BugUrl.pm
added Bugzilla/BugUrl/Trac.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 7706.

I forgot to include r/a information. Sorry...
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: