Closed Bug 5438 Opened 21 years ago Closed 21 years ago

[PP]Mac HTML buttons don't display Unicode correctly

Categories

(SeaMonkey :: UI Design, defect, P3, blocker)

PowerPC
Mac System 8.5
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fergus, Assigned: tague)

References

()

Details

(Whiteboard: DEPEND - Intl - I18n QA BLOCKER - ok for M6)

Take navigator.xul and change a couple of strings to Japanese or to European
extended characters (using Unicode).  Go to a page that has HTML buttons, like
Netcenter's Japanese home page.  On Win, all on-screen widgets look good,
on Mac the text labels of the HTML buttons are corrupted.

It looks like MacFE still expects either Shift-JIS or MacRoman, as appropriate.
It should be looking for and displaying Unicode characters.
Assignee: don → trudelle
QA Contact: 3849 → 4838
see comments for 5402
Assignee: trudelle → evaughan
Target Milestone: M5
reassigning to evaughan as p3 for m5. Eric, this is blocking an I18N M5 task.
Please enlist any Mac debugging assistance you need.
Assignee: evaughan → kmcclusk
This looks like a dup of the bug I just sent you. Draw string does not look like
its doing the right thing underneath.
Target Milestone: M5 → M6
Moving to M6.
Whiteboard: QA BLOCKER
Adding to QA Blocker radar.
Whiteboard: QA BLOCKER → QA BLOCKER - ok for M6
Assignee: kmcclusk → pierre
Pierre, I think this is in the Mac platform specific code so I am reassigning it
to you.
Severity: major → blocker
Fergus: could you give more details in order to reproduce the bug? Like what
strings to modify in navigator.xul, what strings to use instead, what URL to
connect to....
Thanks.
Read the history on bugs 5402 and 5439. Similar problem in different mac
widgets. May want to contact Chris Saari and/or Tague Griffith as they're
working on 5402.  Test file at
http://rocknroll/users/msanz/publish/navigator.zip
Whiteboard: QA BLOCKER - ok for M6 → I18n QA BLOCKER - ok for M6
Status: NEW → ASSIGNED
Target Milestone: M6 → M7
Fergus: how did you manage to display HTML buttons in AppRunner? I can only
display native controls.

Anyhow this won't be fixed for M6: pushing to M7.
*** Bug 6599 has been marked as a duplicate of this bug. ***
Whiteboard: I18n QA BLOCKER - ok for M6 → DEPEND - Intl - I18n QA BLOCKER - ok for M6
Pierre, this can be repro'd by just going to http://home.jp.netscape.com/ja/
The buttons I'm talking about are the default Excite search button etc.
Blocks: 7228
Summary: Mac HTML buttons don't display Unicode correctly → [PP]Mac HTML buttons don't display Unicode correctly
Target Milestone: M7 → M9
Puhing my Mac-specific bugs to M9 before reassigning them to someone else.
Related to bug #4681?
I can't guarantee this, but if the button code is similar to the menu code,
the problem is most likely that the button label string is getting extracted as
a C-string and not a Unicode string.
The problem is in nsMacControl::StringToStr255.  It takes the nsString label of
the button and does a ToCString on the label to create a Pascal string (Str255)
to set as the Mac control label.
Assignee: pierre → tague
Status: ASSIGNED → NEW
Target Milestone: M9 → M7
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
checked in a general fix for macintosh controls.  should be in m7
Status: RESOLVED → VERIFIED
Verifyied against June 18 build.
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.