543859 - Weave allows me to change passphrase to match my password, but not vice-versa

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:

Comment 1

[Daniel Holbert [:dholbert]]

(sorry, hit 'tab + enter' before completing comment 0)

==============
EXPERIMENT A:
 1. In Weave Preferences, click "Manage Account".
 2. Click "Change Password".
 3. Set new password to be the same as your existing Weave secret phrase
 4. [assuming step 3 failed] Cancel out of the change-password dialog.

ACTUAL RESULTS OF A:
In step 3, an alert appears, with title "[Javascript Application]" and contents "The password cannot be the same as the passphrase".

==============
EXPERIMENT B:
 1. In Weave Preferences, click "Manage Account".
 2. Click "Change Secret Phrase".
 3. Set new passphrase to be the same as your existing Weave *password*

ACTUAL RESULTS OF B:
 Success.

==============
EXPERIMENT C:
NOTE: I'm assuming that now, your passphrase and password are identical, because you've completed 'Experiment B'
 1. In Weave Preferences, click "Manage Account".
 2. Click "Change Password".
 3. Type your existing password in all three fields.

ACTUAL RESULTS OF C:
Same alert as Experiment A.  This effectively means that, in this situation, I can't change my password to itself **because the 'new' password matches my passphrase**.  (Note that I believe that this experiment should indeedtrigger a warning, but for a different reason -- see bug 543858)


===========
EXPECTED RESULTS:
Behavior between Experiment A & Experiment B should be consistent -- that is, if we restrict new passwords to be different from the existing passphrase, then we should also restrict new passphrases to be different from the existing password.  Otherwise the restriction is arbitrary and easily gotten-around, and allows us to get into an odd situation as described in Experiment C.

Comment 2

[Daniel Holbert [:dholbert]]

I'm using:
Weave Sync 1.0
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20100202
Minefield/3.7a1pre
Ubuntu 9.10 (Karmic)

Comment 3

[Mike Connor [:mconnor]]

Fixed as a part of bug 545725