544934 - Authenticated username is not used when generating Jabber ID

Status: RESOLVED FIXED

(support.mozilla.org Graveyard :: Chat, defect)

Description

[Matthew Middleton (:zzxc)]

When testing the integrated login functionality, I noticed that Openfire is ignoring the authenticated username (eg. "zzxctest") when different from the principal (eg. "zzxc tikiwiki test").  This test resulted in an invalid Jabber ID of zzxc\20tikiwiki\[e-mail].  Cases in which the migrated username is the same as the Openfire username (eg. zzxc->zzxc) are not affected.

Since this bug breaks post-migration JID retention and allows invalid characters in Jabber ID's, we need a fix before pushing login migration.  I'll have a patch up by EOD today.

Comment 1

[Matthew Middleton (:zzxc)]

Attachment: Use the authenticated username

This fixes the Openfire SASL authentication mechanism such that it uses the authorized Live Chat username returned by the authorization provider, rather than reusing the login name.

This bug affects anyone using an Openfire authentication provider which results in a Jabber ID distinct from the login name, including the SUMO authentication provider.

Comment 2

[Paul Craciunoiu [:paulc]]

(In reply to comment #1)
> Created an attachment (id=426000) [details]
> Use the authenticated username
Not sure how to test this, but it looks like it needs Openfire set up. I'm tied up today until 1pm at the earliest -- James or Laura: can you review this?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

QA is still blocked by this.

Comment 4

[Paul Craciunoiu [:paulc]]

Comment on attachment 426000 [details] [diff] [review]
Use the authenticated username

I can't today. Passing on.

Comment 5

[Laura Thomson :laura]

Comment on attachment 426000 [details] [diff] [review]
Use the authenticated username

It looks reasonable, and I really can't test further without a significant amount of effort - let's get it committed and into QA

Comment 6

[Matthew Middleton (:zzxc)]

Checked in r62173.