Last Comment Bug 545110 - Add/port about:support (Troubleshooting Information page) to SeaMonkey
: Add/port about:support (Troubleshooting Information page) to SeaMonkey
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.1a2
Assigned To: Jens Hatlak (:InvisibleSmiley)
:
:
Mentors:
Depends on: 605658 518607 561668
Blocks: 566646
  Show dependency treegraph
 
Reported: 2010-02-09 06:07 PST by Jens Hatlak (:InvisibleSmiley)
Modified: 2010-10-19 16:24 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
-
wanted


Attachments
add menu item (3.12 KB, patch)
2010-05-16 16:19 PDT, Jens Hatlak (:InvisibleSmiley)
no flags Details | Diff | Splinter Review
menu item v2 (3.10 KB, patch)
2010-05-17 15:02 PDT, Jens Hatlak (:InvisibleSmiley)
neil: review+
neil: superreview+
Details | Diff | Splinter Review
menu item v2a [Checkin: comment 8] (2.84 KB, patch)
2010-05-18 10:07 PDT, Jens Hatlak (:InvisibleSmiley)
jh: review+
jh: superreview+
Details | Diff | Splinter Review
pref patch [Checkin: comment 13] (1020 bytes, patch)
2010-05-22 15:46 PDT, Jens Hatlak (:InvisibleSmiley)
neil: review+
kairo: feedback+
Details | Diff | Splinter Review

Description Jens Hatlak (:InvisibleSmiley) 2010-02-09 06:07:03 PST
Firefox implemented about:support in Bug 367596. Bug 518607 aims at moving the basic functionality to Toolkit. This bug is for tracking/implementing the SeaMonkey side, e.g. string additions (en-US l10n).
Comment 1 Phil Ringnalda (:philor) 2010-02-21 16:41:38 PST
Should just need three things, a string for the menuitem, a menuitem, and a app.support.baseURL pref, so the "support web site" link goes somewhere other than about:blank.

Well, and it would probably be a good idea to look at what prefs with user values show up, to consider whether anything needs to be added to the whitelist and blacklist.
Comment 2 Philip Chee 2010-02-23 11:49:44 PST
Bug 548041 is the Thunderbird version from comment0 there:

> 1. port about:support to Thunderbird
> 2. and add smtp, imap and pop settings suitably obscured

#2 is something we should have too.
Comment 3 Jens Hatlak (:InvisibleSmiley) 2010-04-25 14:35:55 PDT
This is basically working already thanks to the work done by philor. We'll need to port the styles to Modern; filed bug 561668 for that to allow this bug to focus on any non-theme adaptions and customizations.
Comment 4 Jens Hatlak (:InvisibleSmiley) 2010-05-16 16:19:14 PDT
Created attachment 445629 [details] [diff] [review]
add menu item

This is the menu item addition. I left out the onclick=checkForMiddleClick part that FF has for now because we're not using in the other places yet either.

Regarding comment 2 I think that should be a new bug and this one be restricted to adding the menu item.
Comment 5 neil@parkwaycc.co.uk 2010-05-17 07:43:15 PDT
Comment on attachment 445629 [details] [diff] [review]
add menu item

>     openUILink(formatter.formatURLPref("app.releaseNotesURL"));
>   }
>   catch (ex) { dump(ex); }
> }
> 
>+function goTroubleshootingPage()
>+{
>+  openUILinkIn("about:support", "tab");
Why always in a tab?

>+                oncommand="goTroubleshootingPage()"/>
Nit: missing semicolon
Comment 6 Jens Hatlak (:InvisibleSmiley) 2010-05-17 15:02:45 PDT
Created attachment 445824 [details] [diff] [review]
menu item v2

(In reply to comment #5)
> (From update of attachment 445629 [details] [diff] [review])
> >+function goTroubleshootingPage()
> >+{
> >+  openUILinkIn("about:support", "tab");
> Why always in a tab?

Hmm, I didn't really check whether what FF has made sense, sorry. I used
  goAbout("support");
now, wrapped inside goTroubleshootingPage() for FF compatibility. I can call it directly if you're opposed to that, though.

Before I forget: This probably needs a Help bug.
Comment 7 neil@parkwaycc.co.uk 2010-05-18 02:00:34 PDT
Comment on attachment 445824 [details] [diff] [review]
menu item v2

>+function goTroubleshootingPage()
Nit: This belongs before goReleaseNotes()
(sorry I didn't notice last time)
Comment 8 Jens Hatlak (:InvisibleSmiley) 2010-05-18 10:07:57 PDT
Created attachment 445985 [details] [diff] [review]
menu item v2a [Checkin: comment 8]

http://hg.mozilla.org/comm-central/rev/c62f8ae8aef3
Comment 9 Jens Hatlak (:InvisibleSmiley) 2010-05-18 10:22:36 PDT
(In reply to comment #2)
> Bug 548041 is the Thunderbird version from comment0 there:
> 
> > 1. port about:support to Thunderbird
> > 2. and add smtp, imap and pop settings suitably obscured
> 
> #2 is something we should have too.

Not too much has happened there. We can either wait and port what they'll come up with or work in parallel. You may file a bug for SM now or later but as I said I think this one is done, thus resolving.

(In reply to comment #6)
> Before I forget: This probably needs a Help bug.

Filed bug 566646.
Comment 10 Jens Hatlak (:InvisibleSmiley) 2010-05-22 15:43:22 PDT
(In reply to comment #1)
> Should just need three things, a string for the menuitem, a menuitem, and a
> app.support.baseURL pref, so the "support web site" link goes somewhere other
> than about:blank.

Sorry philor, I should have checked your comment more closely. I forgot about the app.support.baseURL part:

Error: formatURLPref: Couldn't get pref: app.support.baseURL
Source File: file:///E:/Programme/seamonkey-trunk/components/nsURLFormatter.js
Line: 68

firefox.js#829:
pref("app.support.baseURL", "http://support.mozilla.com/1/%APP%/%VERSION%/%OS%/%LOCALE%/");

all-thunderbird.js#131:
pref("app.support.baseURL", "http://support.live.mozillamessaging.com/%LOCALE%/%APP%/%APPBUILDID%/");
Comment 11 Jens Hatlak (:InvisibleSmiley) 2010-05-22 15:46:22 PDT
Created attachment 446925 [details] [diff] [review]
pref patch [Checkin: comment 13]

Since we have nothing like SUMO or MoMe's support page (localized, per version etc.) I just used our general support page for now. Can be improved later.

KaiRo, what do you think? Would you recommend another page instead?
Comment 12 Robert Kaiser 2010-05-22 16:07:02 PDT
Comment on attachment 446925 [details] [diff] [review]
pref patch [Checkin: comment 13]

We unfortunately don't have a SUMO install yet, so I guess this is the best we can do for now, yes.
Comment 13 Jens Hatlak (:InvisibleSmiley) 2010-05-22 16:37:35 PDT
Comment on attachment 446925 [details] [diff] [review]
pref patch [Checkin: comment 13]

http://hg.mozilla.org/comm-central/rev/22865b405118

Note You need to log in before you can comment on or make changes to this bug.