Add/port about:support (Troubleshooting Information page) to SeaMonkey

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
General
--
enhancement
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
seamonkey2.1a2
Dependency tree / graph

Firefox Tracking Flags

(blocking-seamonkey2.1 -, seamonkey2.1 wanted)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Firefox implemented about:support in Bug 367596. Bug 518607 aims at moving the basic functionality to Toolkit. This bug is for tracking/implementing the SeaMonkey side, e.g. string additions (en-US l10n).
Should just need three things, a string for the menuitem, a menuitem, and a app.support.baseURL pref, so the "support web site" link goes somewhere other than about:blank.

Well, and it would probably be a good idea to look at what prefs with user values show up, to consider whether anything needs to be added to the whitelist and blacklist.
Depends on: 518607

Comment 2

8 years ago
Bug 548041 is the Thunderbird version from comment0 there:

> 1. port about:support to Thunderbird
> 2. and add smtp, imap and pop settings suitably obscured

#2 is something we should have too.
(Assignee)

Updated

7 years ago
Depends on: 561668
(Assignee)

Comment 3

7 years ago
This is basically working already thanks to the work done by philor. We'll need to port the styles to Modern; filed bug 561668 for that to allow this bug to focus on any non-theme adaptions and customizations.
(Assignee)

Updated

7 years ago
Flags: blocking-seamonkey2.1a1?

Updated

7 years ago
blocking-seamonkey2.1: --- → -
status-seamonkey2.1: --- → wanted
Flags: blocking-seamonkey2.1a1?
(Assignee)

Comment 4

7 years ago
Created attachment 445629 [details] [diff] [review]
add menu item

This is the menu item addition. I left out the onclick=checkForMiddleClick part that FF has for now because we're not using in the other places yet either.

Regarding comment 2 I think that should be a new bug and this one be restricted to adding the menu item.
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #445629 - Flags: superreview?(neil)
Attachment #445629 - Flags: review?(neil)

Comment 5

7 years ago
Comment on attachment 445629 [details] [diff] [review]
add menu item

>     openUILink(formatter.formatURLPref("app.releaseNotesURL"));
>   }
>   catch (ex) { dump(ex); }
> }
> 
>+function goTroubleshootingPage()
>+{
>+  openUILinkIn("about:support", "tab");
Why always in a tab?

>+                oncommand="goTroubleshootingPage()"/>
Nit: missing semicolon
(Assignee)

Comment 6

7 years ago
Created attachment 445824 [details] [diff] [review]
menu item v2

(In reply to comment #5)
> (From update of attachment 445629 [details] [diff] [review])
> >+function goTroubleshootingPage()
> >+{
> >+  openUILinkIn("about:support", "tab");
> Why always in a tab?

Hmm, I didn't really check whether what FF has made sense, sorry. I used
  goAbout("support");
now, wrapped inside goTroubleshootingPage() for FF compatibility. I can call it directly if you're opposed to that, though.

Before I forget: This probably needs a Help bug.
Attachment #445629 - Attachment is obsolete: true
Attachment #445824 - Flags: superreview?(neil)
Attachment #445824 - Flags: review?(neil)
Attachment #445629 - Flags: superreview?(neil)
Attachment #445629 - Flags: review?(neil)

Comment 7

7 years ago
Comment on attachment 445824 [details] [diff] [review]
menu item v2

>+function goTroubleshootingPage()
Nit: This belongs before goReleaseNotes()
(sorry I didn't notice last time)
Attachment #445824 - Flags: superreview?(neil)
Attachment #445824 - Flags: superreview+
Attachment #445824 - Flags: review?(neil)
Attachment #445824 - Flags: review+
(Assignee)

Comment 8

7 years ago
Created attachment 445985 [details] [diff] [review]
menu item v2a [Checkin: comment 8]

http://hg.mozilla.org/comm-central/rev/c62f8ae8aef3
Attachment #445824 - Attachment is obsolete: true
Attachment #445985 - Flags: superreview+
Attachment #445985 - Flags: review+
(Assignee)

Updated

7 years ago
Blocks: 566646
(Assignee)

Comment 9

7 years ago
(In reply to comment #2)
> Bug 548041 is the Thunderbird version from comment0 there:
> 
> > 1. port about:support to Thunderbird
> > 2. and add smtp, imap and pop settings suitably obscured
> 
> #2 is something we should have too.

Not too much has happened there. We can either wait and port what they'll come up with or work in parallel. You may file a bug for SM now or later but as I said I think this one is done, thus resolving.

(In reply to comment #6)
> Before I forget: This probably needs a Help bug.

Filed bug 566646.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
(Assignee)

Comment 10

7 years ago
(In reply to comment #1)
> Should just need three things, a string for the menuitem, a menuitem, and a
> app.support.baseURL pref, so the "support web site" link goes somewhere other
> than about:blank.

Sorry philor, I should have checked your comment more closely. I forgot about the app.support.baseURL part:

Error: formatURLPref: Couldn't get pref: app.support.baseURL
Source File: file:///E:/Programme/seamonkey-trunk/components/nsURLFormatter.js
Line: 68

firefox.js#829:
pref("app.support.baseURL", "http://support.mozilla.com/1/%APP%/%VERSION%/%OS%/%LOCALE%/");

all-thunderbird.js#131:
pref("app.support.baseURL", "http://support.live.mozillamessaging.com/%LOCALE%/%APP%/%APPBUILDID%/");
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 11

7 years ago
Created attachment 446925 [details] [diff] [review]
pref patch [Checkin: comment 13]

Since we have nothing like SUMO or MoMe's support page (localized, per version etc.) I just used our general support page for now. Can be improved later.

KaiRo, what do you think? Would you recommend another page instead?
Attachment #446925 - Flags: review?(neil)
Attachment #446925 - Flags: feedback?(kairo)

Comment 12

7 years ago
Comment on attachment 446925 [details] [diff] [review]
pref patch [Checkin: comment 13]

We unfortunately don't have a SUMO install yet, so I guess this is the best we can do for now, yes.
Attachment #446925 - Flags: feedback?(kairo) → feedback+

Updated

7 years ago
Attachment #446925 - Flags: review?(neil) → review+
(Assignee)

Comment 13

7 years ago
Comment on attachment 446925 [details] [diff] [review]
pref patch [Checkin: comment 13]

http://hg.mozilla.org/comm-central/rev/22865b405118
Attachment #446925 - Attachment description: pref patch → pref patch [Checkin: comment 13]
(Assignee)

Updated

7 years ago
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Depends on: 605658
You need to log in before you can comment on or make changes to this bug.