Closed
Bug 545194
Opened 14 years ago
Closed 11 years ago
Account Settings-->Server username and buttons "Advanced" and "Browse" are cut off
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 18.0
People
(Reporter: Aureliano, Assigned: aceman)
Details
(Keywords: polish)
Attachments
(3 files, 1 obsolete file)
screenshot
This issue is a spin-off of bug #528057. DOM element server.realUsername in account settings-->server is cut off when account is large more than 20 letters.
I find it much worse that the buttons are cut off there. The server name can be scrolled.
Keywords: uiwanted
|
Reporter | |
Comment 3•12 years ago
|
||
(In reply to :aceman from comment #2) > I find it much worse that the buttons are cut off there Yes, it is: changed title according
Summary: Account Settings-->Server username cut off → Account Settings-->Server username and buttons "Advanced" and "Browse" are cut off
Aureliano, do you still see the problem? In current TB, the account settings pane has a horizontal scrollbar if the contents do not fit. You can also resize the window if it is small for you. So that should fix the buttons. But it can be easily done to expand the server name and user name textboxes when the window is resized (like the Local Directory field is done). I can add some flex=1 values where needed. Bwinton, would you accept that?
This is no mockup, I set the needed attributes on the elements via DOM Inspector.
Attachment #662080 -
Flags: ui-review?(bwinton)
Assignee: nobody → acelists
Keywords: uiwanted
OS: Windows 7 → All
Product: Thunderbird → MailNews Core
Hardware: x86 → All
Attachment #662080 -
Flags: feedback?(euryalus.0)
Attachment #662313 -
Flags: ui-review?(bwinton)
Attachment #662313 -
Flags: review?(mconley)
|
||
Comment 8•11 years ago
|
||
Comment on attachment 662313 [details] [diff] [review] patch Yeah, that makes sense. ui-r=me! Thanks, Blake.
Attachment #662313 -
Flags: ui-review?(bwinton) → ui-review+
|
|
||
Updated•11 years ago
|
Attachment #662080 -
Flags: ui-review?(bwinton)
Attachment #662313 -
Flags: review?(iann_bugzilla)
Comment on attachment 662313 [details] [diff] [review] patch >+ <textbox wsm_persist="true" >+ size="20" flex="1" This is the only line you've not got one attribute per line! >+ id="server.realHostName" >+ prefstring="mail.server.%serverkey%.realhostname" >+ class="uri-element"/> >+ <textbox wsm_persist="true" >+ size="20" flex="1" This is the only line you've not got one attribute per line! >+ id="server.realUsername" > prefstring="mail.server.%serverkey%.realusername"/>
Attachment #662313 -
Flags: review?(iann_bugzilla) → review+
|
Assignee | |
Comment 10•11 years ago
|
||
Thanks.
Attachment #662313 -
Attachment is obsolete: true
Attachment #662313 -
Flags: review?(mconley)
Attachment #664218 -
Flags: review?(mconley)
|
|
Reporter | |
Comment 11•11 years ago
|
||
Comment on attachment 662080 [details] screenshot of proposal from comment 5 Sorry for the delay: look good for me! Thanks :aceman
Attachment #662080 -
Flags: feedback?(euryalus.0) → feedback+
|
||
Comment 12•11 years ago
|
||
Comment on attachment 664218 [details] [diff] [review] patch v2 Review of attachment 664218 [details] [diff] [review]: ----------------------------------------------------------------- This looks OK to me. Thanks aceman!
Attachment #664218 -
Flags: review?(mconley) → review+
Keywords: checkin-needed
|
||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9c73c166f56e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in
before you can comment on or make changes to this bug.
Description
•