54520 - Extra carriage return with bullets

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[bijals (gone)]

Steps:
1) Open a blank Composer document
2) Type "asdf"
3) Put caret in between "a" and "s" and hit return
4) Click the bullet icon several times

Actual Results: Get all these carriage returns and caret in front of bullet.

Expected Results: Caret moves to bullet and clicking bullet icon multiple times
does not add carriage returns

Build Date/Platform: 2000092808 using NT

Comment 1

[Charles Manske]

Strange list behavior! Hopefully, not a really common pattern. Setting to 
future.

Comment 2

[Joe Francis]

hmmm... I thought I had stamped all these out.  I bet we can fix for rtm.  Beth, 
will you nominate?

Comment 3

[Joe Francis]

moz 0.9

Comment 4

[Joe Francis]

appeasing bug gods

Comment 5

[rubydoo123]

*** Bug 83158 has been marked as a duplicate of this bug. ***

Comment 6

[Joe Francis]

fixed by patch in 54539

Comment 7

[Joe Francis]

need a=

Comment 8

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for the trunk

Comment 9

[Kathleen :Brade]

so I see this problem with the current fix:
  overeager removal of br's

to reproduce:
 * Create Composer document that looks like this:
Aasdf
Basdf
Casdf
Dasdf
Easdf
 * place the caret before "Basdf"
 * click the bullet list icon
 * click the bullet list icon again
Notice that "Casdf" is now on the same line with Basdf
 * click the bullet list icon a few more times
Notice that all of the lines (after the first line) become one line

Comment 10

[kinmoz]

Joe, the bug that brade points out is happening because PopList pushes the list 
item at the beginning of the list, in front of the list, so when you try to 
unwrap the contents of the list item with a call to RemoveBlockContainer() it 
fails to add a BR because the list item is followed by a "block", which in this 
case is the list it was moved out of.

Comment 11

[Joe Francis]

thanks kathy, kin.  i think i fixed that over the weekend but didnt update my
patch.  I'll make sure I fix it for landing.

Comment 12

[Joe Francis]

fix checked in

Comment 13

[sujay]

the carriage returns are fixed...but I still get caret in front of bullet.

filing new bug.