Bug 521523 regressed libunixproxy.so packaging

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
Build Config
--
minor
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({regression})

Trunk
seamonkey2.1a2
All
Linux
regression
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1265531400.1265537595.19916.gz&fulltext=1
Linux comm-central-trunk nightly on 2010/02/07 00:30:00
{
make package-compare

-bin/components/libunixproxy.so
}

It looks like it lost its '#ifndef MOZ_STATIC_BUILD'.
Flags: in-testsuite-
(Assignee)

Updated

7 years ago
Blocks: 564657
(Assignee)

Updated

7 years ago
Assignee: nobody → sgautherie.bz
Severity: trivial → major
Status: NEW → ASSIGNED
Depends on: 564654
Hardware: x86 → All
(Assignee)

Updated

7 years ago
Severity: major → minor
(Assignee)

Comment 1

7 years ago
Created attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]
Attachment #444459 - Flags: review?(kairo)
(Assignee)

Updated

7 years ago
Attachment #444459 - Flags: review?(bugspam.Callek)
Comment on attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]

>+  #ifdef XP_WIN

Preprocessor can't interpret with spaces preceding this.

Also, please simply fix the regression here than trying (again!) to reorder stuff.
Attachment #444459 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 3

7 years ago
(In reply to comment #2)

> Preprocessor can't interpret with spaces preceding this.

Oh? What error do you get?

> Also, please simply fix the regression here than trying (again!) to reorder
> stuff.

Why not group these files as other related ones are?

Comment 4

7 years ago
Comment on attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]

OK, but please don't change the indentation in this patch.
Either we change it everywhere in this file (at once) or nowhere, but please not for some parts and not for the rest.
Attachment #444459 - Flags: review?(kairo) → review+
(Assignee)

Comment 5

7 years ago
Comment on attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]


http://hg.mozilla.org/comm-central/rev/b71ecabf4d40
Av1, with comment 4 suggestion(s).
Attachment #444459 - Attachment description: (Av1) Fix regression, Group related files → (Av1) Fix regression, Group related files [Checkin: See comment 5]
Attachment #444459 - Flags: review-
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.1a1 → seamonkey2.1a2
(Assignee)

Updated

7 years ago
Depends on: 515374
No longer depends on: 564654
(Assignee)

Updated

6 years ago
No longer depends on: 515374
You need to log in before you can comment on or make changes to this bug.