Closed
Bug 545631
Opened 15 years ago
Closed 15 years ago
Bug 521523 regressed libunixproxy.so packaging
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a2
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
4.91 KB,
patch
|
kairo
:
review+
|
Details | Diff | Splinter Review |
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1265531400.1265537595.19916.gz&fulltext=1
Linux comm-central-trunk nightly on 2010/02/07 00:30:00
{
make package-compare
-bin/components/libunixproxy.so
}
It looks like it lost its '#ifndef MOZ_STATIC_BUILD'.
Flags: in-testsuite-
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → sgautherie.bz
Severity: trivial → major
Status: NEW → ASSIGNED
Depends on: 564654
Hardware: x86 → All
Assignee | ||
Updated•15 years ago
|
Severity: major → minor
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #444459 -
Flags: review?(kairo)
Assignee | ||
Updated•15 years ago
|
Attachment #444459 -
Flags: review?(bugspam.Callek)
Comment 2•15 years ago
|
||
Comment on attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]
>+ #ifdef XP_WIN
Preprocessor can't interpret with spaces preceding this.
Also, please simply fix the regression here than trying (again!) to reorder stuff.
Attachment #444459 -
Flags: review?(bugspam.Callek) → review-
Assignee | ||
Comment 3•15 years ago
|
||
(In reply to comment #2)
> Preprocessor can't interpret with spaces preceding this.
Oh? What error do you get?
> Also, please simply fix the regression here than trying (again!) to reorder
> stuff.
Why not group these files as other related ones are?
Comment 4•15 years ago
|
||
Comment on attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]
OK, but please don't change the indentation in this patch.
Either we change it everywhere in this file (at once) or nowhere, but please not for some parts and not for the rest.
Attachment #444459 -
Flags: review?(kairo) → review+
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 444459 [details] [diff] [review]
(Av1) Fix regression, Group related files
[Checkin: See comment 5]
http://hg.mozilla.org/comm-central/rev/b71ecabf4d40
Av1, with comment 4 suggestion(s).
Attachment #444459 -
Attachment description: (Av1) Fix regression, Group related files → (Av1) Fix regression, Group related files
[Checkin: See comment 5]
Attachment #444459 -
Flags: review-
Assignee | ||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: seamonkey2.1a1 → seamonkey2.1a2
Assignee | ||
Updated•14 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•