545762 - cannot run tests when using PERL5LIB (e.g. when using local::lib)

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Gabor Szabo]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100106 Ubuntu/9.10 (karmic) Firefox/3.5.7
Build Identifier: 

When trying to run ./runtests.pl the test t/001compile.t blows up as I am using
local::lib and I have PERL5LIB configured to locate the privately installed
modules. PERL5LIB is disregarded due to the use of -T in the tests script.


Reproducible: Always

Steps to Reproduce:
1. run ./runtests.pl

Actual Results:  
Cannot find various CPAN modules

Comment 1

[Gabor Szabo]

Attachment: v1_allow_perl5lib.diff

passing values of PERL5LIB as -I on the command line

Comment 2

[Max Kanat-Alexander]

Comment on attachment 426585 [details] [diff] [review]
v1_allow_perl5lib.diff

Looks reasonable. I don't think the "use Config" is necessary though, right?

Comment 3

[Gabor Szabo]

As I could see it is necessary to make the code platform independent.

Comment 4

[Max Kanat-Alexander]

Oh, are there platforms where $ENV{PERL5LIB} won't exist if you don't use Config? That doesn't make sense, since it's an environment variable, right?

Comment 5

[Gabor Szabo]

I have to split PERL5LIB on $Config{path_sep} and not just on double-colon (:) as I did in the patch I sent to the mailing list to make it work on other platforms as well. On Windows it is semi-colon (;).

Comment 6

[Max Kanat-Alexander]

Ahh, okay. That makes sense.

Comment 7

[Max Kanat-Alexander]

  Thanks for the patch! :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified t/001compile.t
Committed revision 6989.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified t/001compile.t
Committed revision 6974.