Closed
Bug 714074
Opened 13 years ago
Closed 13 years ago
Test 1 fails if PERLLIB contains paths with whitespace
Categories
(Bugzilla :: Testing Suite, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: Wurblzap, Assigned: Wurblzap)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
449 bytes,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
This is a regression of bug 545762, affecting all branches starting with 3.6 up to trunk. Library path components must be quoted in test 1 so that spaces in them don't confuse the Perl runtime. Now: perl -I/my path/ -wc$T $file With a PERLLIB containing a path component with a space, this leads to runtests.pl 1 failing with "No such file or directory". Quoting alleviates this. With patch: perl -I"/my path/" -wc$T $file
Attachment #584753 -
Flags: review?(mkanat)
|
Assignee | |
Updated•13 years ago
|
Attachment #584753 -
Flags: review?(mkanat) → review?(gerv)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 584753 [details] [diff] [review] Patch r=gerv. Gerv
Attachment #584753 -
Flags: review?(gerv) → review+
|
||
Comment 2•13 years ago
|
||
Marc, do you have bzr commit access?
Flags: approval4.2+
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Yes. Thanks for the review! Tip: Committing to: bzr+ssh://wurblzap%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified t/001compile.t Committed revision 8113. 4.2: Committing to: bzr+ssh://wurblzap%40gmail.com@bzr.mozilla.org/bugzilla/4.2/ modified t/001compile.t Committed revision 8028. 4.0: Committing to: bzr+ssh://wurblzap%40gmail.com@bzr.mozilla.org/bugzilla/4.0/ modified t/001compile.t Committed revision 7693. 3.6: Committing to: bzr+ssh://wurblzap%40gmail.com@bzr.mozilla.org/bugzilla/3.6/ modified t/001compile.t Committed revision 7280.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•