545822 - Implement AuthProvider to handle login migration on Openfire

Status: VERIFIED FIXED

(support.mozilla.org Graveyard :: Chat, defect)

Description

[Matthew Middleton (:zzxc)]

Attachment: SumoAuthProvider implementation for Openfire

This is the Openfire side of the login migration in bug 503215, consisting of an AuthProvider implementation that reads the TikiWiki database.

The attached code is currently on chat-support-stage at http://chat-support-stage.mozilla.com:9091/ , where it can be tested.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Does this block 1.5.1?  The milestone is unset, and it's a little unclear, even though it's blocking bug 503215.

Comment 2

[Laura Thomson :laura]

(In reply to comment #1)
> Does this block 1.5.1?  The milestone is unset, and it's a little unclear, even
> though it's blocking bug 503215.

Yep, added milestone.

Comment 3

[Matthew Middleton (:zzxc)]

This blocks enabling login migration on production, but it doesn't block the other code in the release.  The Openfire update and restart will need to happen once the migration scripts are in place on TikiWiki, as the AuthProvider depends on the TikiWiki database schema update.

This was originally an Openfire plugin, but I moved the code into the main classpath to prevent issues if the plugin is restarted.  It's still possible to update this without upgrading Openfire, but doing so would require IT to upload a file.  (In any case, this needs to be used with Openfire built from https://svn.mozilla.org/projects/livechat/trunk , as it won't work properly with the build from Jive)

Comment 4

[Paul Craciunoiu [:paulc]]

(In reply to comment #3)
> as the AuthProvider depends on the TikiWiki database schema update.
You mean the added livechat_id column in the users_users table?

Comment 5

[Austin King [:ozten]]

Comment on attachment 426641 [details] [diff] [review]
SumoAuthProvider implementation for Openfire

Good use of prepared statements.

Good use of Exceptions to catch invalid inputs, states.

Consider breaking 'authenticate' into smaller methods. Line: 135 could be a migrate user method called from authenticate, etc so that no method is longer than a screen or two.

Line 286-294: If any of these options are likely to change, we should break those out into config.

General feedback - Consider using DB result set methods that take the name of the column, instead of the index. We won't have to comment the line, if the SQL adds a parameter you don't have to update the line of code.

Nice work!

Code reviewed w/o testing or applying patch.

Comment 6

[Matthew Middleton (:zzxc)]

This is checked in r62183.

Comment 7

[Matthew Middleton (:zzxc)]

(In reply to comment #4)
> (In reply to comment #3)
> > as the AuthProvider depends on the TikiWiki database schema update.
> You mean the added livechat_id column in the users_users table?

Yes

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; Vishal and I have tested migration (both automated and manually), and it works for us.