Closed
Bug 545970
Opened 15 years ago
Closed 15 years ago
Autoscroll widget doesn't appear or wrong image appears in certain cases
Categories
(Toolkit :: UI Widgets, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: martijn.martijn, Assigned: Swatinem)
References
Details
(Keywords: testcase)
Attachments
(2 files)
|
360 bytes,
text/html
|
Details | |
|
5.70 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
See testcase, in the first block, no autoscroll image appears on middle-click.
In the second block, the wrong autoscroll image appears.
I guess the logic for detecting overflow is not completely right.
|
Assignee | |
Comment 1•15 years ago
|
||
So what happened is this: It used offsetWidth/Height (the outer width, as in width + borders) to determine whether to scroll, instead of clientWidth/Height, which is the actual visible area of the contents.
Strange, the mochitest does not pass for elements that are not visible in the browser window. Packing the test divs tighter together using display: inline-block fixes that problem.
|
||
Updated•15 years ago
|
Attachment #426818 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Comment on attachment 426818 [details] [diff] [review]
fix [pushed: comment 2]
http://hg.mozilla.org/mozilla-central/rev/78cf81cafcff
Attachment #426818 -
Attachment description: fix → fix [pushed: comment 2]
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 3•15 years ago
|
||
Thanks for fixing, verified fixed, using: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100219 Minefield/3.7a2pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•