Closed Bug 695121 Opened 14 years ago Closed 14 years ago

Auto scroll does not work on https://beta.mozillalabs.com/en-US/

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: sdrocking, Assigned: Swatinem)

References

Details

(Keywords: regression)

Attachments

(2 files)

reduced html
227 bytes, text/html
Details
fix
1.89 KB, patch
neil
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:10.0a1) Gecko/20111017 Firefox/10.0a1 Build ID: 20111017031010 Actual results: Auto-scrolling doesn't work in Firefox but works in Chrome. Also middle click to scroll doesn't work.
Status: UNCONFIRMED → NEW
Component: General → Layout
Ever confirmed: true
QA Contact: general → layout
Hardware: x86 → All
Why is this a layout issue, exactly?
Same behavior in Aurora: User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a2) Gecko/20111017 Firefox/9.0a2 Build ID: 20111017042016
We sure this is not a site issue ? It does not scroll in 7.0.1 on XP SP3 either... STR. 1. Visit link/site 2. middle click to activate scrolling in Windows 3. Page does not scroll. Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Confirmed. Didn't work on Firefox 10 neither in the version 8 beta 3. Works perfectly on IE9 and Chrome14.
Attached file reduced html —
Regression window(m-c), Works: http://hg.mozilla.org/mozilla-central/rev/bfe41dab22a5 Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100218 Minefield/3.7a2pre ID:20100218120751 Fails: http://hg.mozilla.org/mozilla-central/rev/78cf81cafcff Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a2pre) Gecko/20100219 Minefield/3.7a2pre ID:20100219043233 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bfe41dab22a5&tochange=78cf81cafcff
Auto Scrolls if you middle click in the vertical scroll-bar just my 2 cents
Blocks: 545970
Component: Layout → XUL Widgets
Keywords: regression
OS: Windows 7 → All
Product: Core → Toolkit
QA Contact: layout → xul.widgets
WORKAROUND: append the following css to userContent.css body{ border:none !important; }
<body> needs to be excluded from overflow-based autoscroll since it does not allow .scrollTop to be set. I will work up a patch later today.
Assignee: nobody → arpad.borsos
Status: NEW → ASSIGNED
Attached patch fix — — Splinter Review
Attachment #567754 - Flags: review?(neil)
(In reply to Arpad Borsos from comment #9) > <body> needs to be excluded from overflow-based autoscroll since it does not > allow .scrollTop to be set. Actually it's a little more complicated than that. In quirks mode, document.body.scrollTop == window.scrollY while document.document.scrollTop is always zero. In strict mode, document.documentElement.scrollTop == window.scrollY while document.body.scrollTop is always zero. Fortunately the patch is able to ignore this by using the window methods instead of trying to work out whether to use the document element or body.
Attachment #567754 - Flags: review?(neil) → review+
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e67f08f9a08 Thanks and sorry for the delay.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/1e67f08f9a08 please, don't mark bugs as fixed till they reach mozilla-central.
Target Milestone: --- → mozilla10
Depends on: 914251
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: