Closed Bug 546255 Opened 14 years ago Closed 14 years ago

Make nsIBrowserHistory.[un]registerOpenPage async

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Milestone:
mozilla2.0b4

People

(Reporter: Unfocused, Assigned: mak)

References

Details

Followup to bug 480350.

nsIBrowserHistory.registerOpenPage() and nsIBrowserhistory.unregisterOpenPage() use synchoronous DB calls, and are called on each pageload. This kills babies. Make them async.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
(In reply to comment #0)
> Make them async.

i must note that joining by uri would solve this without need to make this async, and would also go toward direction of bug 546253
(In reply to comment #1)
> i must note that joining by uri would solve this without need to make this
> async, and would also go toward direction of bug 546253

Hm, hadn't concidered that - thanks! Would also mean the tests won't need to be chsnged to deal with async either.
i think i pointed out this possible solution in my review in bug 480350, sorry if i was unclear.
Since now we just store in a temp table without touching disk tables, this bug is now useless. Fixed with bug 546253.
Assignee: bmcbride → mak77
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Depends on: 546253
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
well, better WONTFIX since they are not async.
Resolution: FIXED → WONTFIX
You need to log in before you can comment on or make changes to this bug.