Make nsIBrowserHistory.[un]registerOpenPage async

RESOLVED WONTFIX

Status

()

Toolkit
Places
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: Unfocused, Assigned: mak)

Tracking

unspecified
mozilla2.0b4
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Followup to bug 480350.

nsIBrowserHistory.registerOpenPage() and nsIBrowserhistory.unregisterOpenPage() use synchoronous DB calls, and are called on each pageload. This kills babies. Make them async.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
OS: Windows 7 → All
Hardware: x86 → All
(Assignee)

Comment 1

7 years ago
(In reply to comment #0)
> Make them async.

i must note that joining by uri would solve this without need to make this async, and would also go toward direction of bug 546253
(In reply to comment #1)
> i must note that joining by uri would solve this without need to make this
> async, and would also go toward direction of bug 546253

Hm, hadn't concidered that - thanks! Would also mean the tests won't need to be chsnged to deal with async either.
(Assignee)

Comment 3

7 years ago
i think i pointed out this possible solution in my review in bug 480350, sorry if i was unclear.
Blocks: 480350
No longer depends on: 480350
(Assignee)

Comment 4

7 years ago
Since now we just store in a temp table without touching disk tables, this bug is now useless. Fixed with bug 546253.
Assignee: bmcbride → mak77
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Depends on: 546253
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
(Assignee)

Comment 5

7 years ago
well, better WONTFIX since they are not async.
Resolution: FIXED → WONTFIX
You need to log in before you can comment on or make changes to this bug.