Closed Bug 546253 Opened 11 years ago Closed 11 years ago
_openpages _temp table needs to describe pages that may not be in moz _places
Followup for bug 480350. The moz_openpages_temp currently joins with moz_places based on ID. However, if an open page has been removed from history, then it won't register as being open, since there will be no corresponding row in moz_places to join with. To solve this, moz_openpages_temp could instead hold URL and title, and join based on URL.
Duplicate of this bug: 558368
Definitely blocks, but we wouldn't hold beta1 for it
blocking2.0: beta1+ → final+
is this also relevant for switching to "about:" pages, or should i file a separate bug for that?
this fix should work for about: pages afaict.
stealing for now, I need this sooner than later, due to add page contentions with async visitURI
Assignee: bmcbride → mak77
(In reply to comment #6) > stealing for now, I need this sooner than later, due to add page contentions > with async visitURI Can you updated the dependencies?
(In reply to comment #7) > (In reply to comment #6) > > stealing for now, I need this sooner than later, due to add page contentions > > with async visitURI > Can you updated the dependencies? bug 585966 is already in the blocks section of this bug, could also help bug 559217
Comment on attachment 464653 [details] [diff] [review] patch v1.0 this also moves up results in the list, that was requested in another bug (but was easier to do it here). The backend (register/unregister) part is something we want regardless, the ordering of the results changes here and would be nice to get users feedback.
Attachment #464653 - Flags: review?(sdwilsh)
Comment on attachment 464653 [details] [diff] [review] patch v1.0 r=sdwilsh
Attachment #464653 - Flags: review?(sdwilsh) → review+
there is probably some glitch with about:blank registration since I see a related failure on tryserver: http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1281549452.1281550402.29118.gz TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/base/content/test/browser_tabMatchesInAwesomebar.js | tab is open (1 times) and should recorded in db: about:blank Or it's just a timing issue of the test that should wait visits addition (bug 576605 has a wip patch for that).
the test failure is caused by bug 586506 (browser_bug380960.js is the origin of the unmatching tab).
switch to tab was covering a missing change in docshell, will try to get a diff review
Attachment #464653 - Attachment is obsolete: true
just a fix to a comment.
Attachment #465797 - Attachment is obsolete: true
Comment on attachment 465801 [details] [diff] [review] patch v1.2 asking review on the small dochell change, the design of switch to tab was covering the fact docshell was still trying to set title synchronously before adding a page.
Attachment #465801 - Flags: review?(sdwilsh)
Comment on attachment 465801 [details] [diff] [review] patch v1.2 r=sdwilsh on the docshell changes
Attachment #465801 - Flags: review?(sdwilsh) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.