546358 - With Flashblock enabled, Silverlight content is not visible. No way to unblock it.

Status: VERIFIED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[philippe (part-time)]

STR:
1. enable Flashblock
2. load URL

AR: only a fragment of the page is visible. mousing over the middle of the page shows a tooltip. Clicking on it does nothing.
ER: a visible overlay / something to unblock the movie

This is a side effect of bug 537993 (Flashblock 1.5.12)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When I read the Flashblock code for the upgrade, it seemed to me that we'd have to pass Flashblock.xml a "true" value for the equivalent of the variable Flashblock.js sets when it reads the flashblock.silverlight.blocked pref[1] in order to get Silverlight to be blocked.  Did I miss something (like an assumption somewhere that the variable is "true" when not set)?

[1]
http://www.mozdev.org/source/browse/flashblock/source/content/flashblock/flashblock.js.diff?r1=1.44.2.33;r2=1.44.2.34;only_with_tag=FLASHBLOCK_1_5_CLEANUP_BRANCH;f=h

This is bad, and needs to block 2.0.2 :(

We either need to 

1) back-out bug 537993 and revise the release notes, or 
2) back out the Silverlight part of bug 537993, or 
3) fix our Cocoa code to always send a "false" to Flashblock.xml, or 
4) completely implement support for the flashblock.silverlight.blocked pref (and package the silverplay.png file)

I guess I'll start working on 2.

Comment 2

[Philip Chee]

Oops sorry for not making clear that due to demand I've started blocking Silverlight as well. Apologies.

Comment 3

[Philip Chee]

Removing this bit from the flashblock.css should remove Silverlight blocking:

/*
* Silverlight identifiers.
*/
object[classid*="32C73088-76AE-40F7-AC40-81F62CB2C1DA"],
object[type="application/ag-plugin"],
object[type="application/x-silverlight"],
object[type="application/x-silverlight-2"],
object[source*=".xaml"],
object[sourceelement*="xaml"],
object[data*="application/x-silverlight"],
embed[type="application/ag-plugin"],
embed[source*=".xaml"]
{ -moz-binding: url("chrome://flashblock/content/flashblock.xml#silverlight") !important; }

Comment 4

[Christopher Henderson]

Attachment: Fix v1.0

Adds the Silverblock preference and associated event handlers. Due to a bug in the current Flashblock, which doesn't load the blocked object when the placeholder is clicked, we always allow Silverlight objects.

Once the Flashblock bug is fixed we can preventDefault depending on the state of the preference.

Comment 5

[philippe (part-time)]

For reference, I reported the Flashblock bug as
https://www.mozdev.org/bugs/show_bug.cgi?id=22469

Comment 6

[Stuart Morgan]

Comment on attachment 427075 [details] [diff] [review]
Fix v1.0

r=smorgan. Maybe put a comment in the method explaining why you are calling it unconditionally at the moment?

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 427075 [details] [diff] [review]
Fix v1.0

sr=pink

Comment 8

[Christopher Henderson]

Attachment: Fix v1.1, for checkin

Adds a comment to |onSilverblockCheck|. Same as v1.0 otherwise.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed this on cvs trunk and the CAMINO_2_0_BRANCH in advance of Camino 2.0.2.  Thanks, everyone!

Comment 10

[Philip Chee]

FYI in the Flashblock cvs I have flipped the silverlight blocking default preference setting to false. It used to work but after the latest Silverlight plugin updates, blocked SL can't be unblocked.

Comment 11

[philippe (part-time)]

Verified with Version 2.1a1pre (1.9.0.19pre 2010021700).