Closed Bug 537993 Opened 14 years ago Closed 14 years ago

Upgrade to Flashblock 1.5.12

Categories

(Camino Graveyard :: Annoyance Blocking, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alqahira, Assigned: alqahira)

References

Details

(Whiteboard: [camino-2.0.2])

Attachments

(1 file)

There's a new version of Flashblock out, 1.5.12:

* [fix] Bug 20817  Make Flowplayer work with Flashblock instead of offering to download the .flv file. Includes a followup fix to include other formats offered for download including .MP4
* Ongoing refactoring of Flashblock code.
* Detect more broken flash and stealth flash objects.
* Add ".*" to the end of the whitelist strings during compare so users don't have to do this manually.
* Initial support for blocking Silverlight. Thanks to Sven Schneider for the silverlight buttons

Some of that doesn't apply to us (anything in flashblock.js, for instance).  Also, it looks like if we want to include the Silverlight support, we'll have to do some checking of the hidden pref for Silverlight support and passing some variables[1], as IIRC our equivalent of the flashblock.js is assorted Cocoa code.  If we want to enable that support by default, we'd also need to write that pref.

[1] http://www.mozdev.org/source/browse/flashblock/source/content/flashblock/flashblock.js.diff?r1=1.44.2.33;r2=1.44.2.34;only_with_tag=FLASHBLOCK_1_5_CLEANUP_BRANCH;f=h
Flags: camino2.0.2?
Here's a patch that upgrades us to 1.5.12.  I've run it through the standard set of tests without problem.

Note that we don't pick up the Silverlight blocking mentioned above; if we want to support that, we'll have to write code in another bug ;)
Assignee: nobody → alqahira
Status: NEW → ASSIGNED
Attachment #424185 - Flags: superreview?(stuart.morgan+bugzilla)
Attachment #424185 - Attachment is patch: true
Attachment #424185 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 424185 [details] [diff] [review]
Upgrade to 1.5.12

sr=smorgan
Attachment #424185 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed on cvs trunk and the CAMINO_2_0_BRANCH, with the README change that was in my tree and somehow missed the diff even after I rediffed the other day specifically to pick up that change!

Not sure if we want this for 1.6.11 or not; we'll see.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: camino2.0.2?
Flags: camino2.0.2+
Flags: camino1.6.11?
Resolution: --- → FIXED
Whiteboard: [camino-2.0.2]
(In reply to comment #3)
> Not sure if we want this for 1.6.11 or not; we'll see.

Based on bug 546358, I think 1.5.11 is going to be the end-of-the-road for 1.6.x.
Flags: camino1.6.11? → camino1.6.11-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: