Closed Bug 546487 Opened 14 years ago Closed 14 years ago

Remove 1.9.2 ifdefs from suite/ on comm-central

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.1a1

People

(Reporter: kairo, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(2 files)

(Av1) The non-installer part [Checkin: Comment 5]
2.77 KB, patch
neil
: review+
neil
: superreview+
Details | Diff | Splinter Review
(Bv1) The installer part [Checkin: Comment 7]
6.40 KB, patch
Callek
: review+
Details | Diff | Splinter Review 
As we de-support 1.9.2 for SeaMonkey builds on comm-central, we should remove the ifdefs for that from the suite/ directory once bug 546484 has been solved (not before, so that we don't give people broken builds).
Not too bad:
"Found 52 matching lines in 6 files"
which are 95% in /installer/.
URL: http://mxr.mozilla.org/comm-central/s...
Severity: normal → trivial
Flags: in-testsuite-
OS: Linux → All
Hardware: x86 → All
And a few of those are going away in bug 545534 actually, as Walter needed to touch a number of them in any case.
Depends on: 545534
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED

        Attachment #427493 -
        Flags: superreview?(neil)

        Attachment #427493 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 427493 [details] [diff] [review]
(Av1) The non-installer part
[Checkin: Comment 5]

>- * MOZILLA_1_9_2_BRANCH
Nice of Ratty to make this easily discoverable ;-)

        Attachment #427493 -
        Flags: superreview?(neil)

        Attachment #427493 -
        Flags: superreview+

        Attachment #427493 -
        Flags: review?(neil)

        Attachment #427493 -
        Flags: review+

    
    

    
  
Comment on attachment 427493 [details] [diff] [review]
(Av1) The non-installer part
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/6eca7164d6b0

        Attachment #427493 -
        Attachment description: (Av1) The non-installer part → (Av1) The non-installer part
[Checkin: Comment 5]

    
  
Depends on: 521624

    
    

    
  


  

        Attachment #427904 -
        Flags: review?(bugspam.Callek)

        Attachment #427904 -
        Flags: review?(bugspam.Callek) → review+

    
    

    
  
Comment on attachment 427904 [details] [diff] [review]
(Bv1) The installer part
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/26f10666fd13

        Attachment #427904 -
        Attachment description: (Bv1) The installer part → (Bv1) The installer part
[Checkin: Comment 7]

    
  
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1

          You need to log in
          before you can comment on or make changes to this bug.