Closed Bug 546484 (NoC192SM) Opened 10 years ago Closed 10 years ago

Error out on building SeaMonkey with 1.9.2 from comm-central

Categories

(SeaMonkey :: Build Config, defect, major)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a1

People

(Reporter: kairo, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

As we decided to unsupport 1.9.2 for SeaMonkey on comm-central, we should error out on building with 1.9.2 from that tree, so people do not end up with broken, unsupported configurations inadvertently.
Blocks: 546487
Attached patch (Av1) Just error out (obsolete) — Splinter Review
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #427258 - Flags: review?(kairo)
Comment on attachment 427258 [details] [diff] [review]
(Av1) Just error out

> # Now is a good time to test for logic errors, define mismatches, etc.
> case "$MOZ_BUILD_APP" in
> xulrunner)
>   if test "$LIBXUL_SDK"; then
>     AC_MSG_ERROR([Building XULRunner --with-libxul-sdk doesn't make sense; XULRunner provides the libxul SDK.])
>   fi
>   ;;
>-esac

Don't join those case statements, they are for different reasons, as the comments explain. I wonder if building XULRunner from comm-central makes any sense at all, actually, but that's a different bug.

> # Special cases where we need to AC_DEFINE something. Also a holdover for apps
> # that haven't made a confvars.sh yet. Don't add new stuff here, use
> # MOZ_BUILD_APP.
>-case "$MOZ_BUILD_APP" in
> suite)
>+  if test "$MOZILLA_1_9_2_BRANCH" = "1"; then
>+    AC_MSG_ERROR([Building SeaMonkey with mozilla1.9.2 is not supported.])
>+  fi
>   AC_DEFINE(MOZ_SUITE)
>   ;;
>-
> mail)
>   AC_DEFINE(MOZ_THUNDERBIRD)
>   ;;
>-
> calendar)
>   AC_DEFINE(MOZ_SUNBIRD)
>   ;;
>-
> esac

Please leave those newlines in.

Also, did you try if we can do this in confvars.sh? If it works, I'd prefer that. The whole block of AC_DEFINEs here should actually go away at some stage, if possible...
Blocks: 541723
Blocks: 545534
Av1, with comment 2 suggestion(s).

(In reply to comment #2)

> I wonder if building XULRunner from comm-central makes any
> sense at all, actually, but that's a different bug.

Yeah, I thought about it too in the meantime... ;-)

> Also, did you try if we can do this in confvars.sh?

configure executes |. "${srcdir}/${MOZ_BUILD_APP}/confvars.sh"|.
I have no idea how to error out (from) there.

> The whole block of AC_DEFINEs here should actually go away at some stage,

Does it really matter for this ("short lived") code?
Attachment #427258 - Attachment is obsolete: true
Attachment #427354 - Flags: review?(kairo)
Attachment #427258 - Flags: review?(kairo)
Alias: NoC192SM
Severity: normal → major
Flags: in-testsuite-
Blocks: 511884
Blocks: 536374
Blocks: 540380
Comment on attachment 427354 [details] [diff] [review]
(Av2) Just error out
[Checkin: Comment 5]

Yes, I don't completely love it, but let's just do it.
Attachment #427354 - Flags: review?(kairo) → review+
Comment on attachment 427354 [details] [diff] [review]
(Av2) Just error out
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/0cdce605ea0c
Attachment #427354 - Attachment description: (Av2) Just error out → (Av2) Just error out [Checkin: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 540470
Blocks: 521624
Blocks: 511896
Blocks: 547375
Blocks: 538753
Blocks: 536567
No longer blocks: 536567
Blocks: C192ConfSync
Blocks: 547039
Blocks: 522712
Blocks: 549293
No longer blocks: 540380
You need to log in before you can comment on or make changes to this bug.