Last Comment Bug 546484 - (NoC192SM) Error out on building SeaMonkey with 1.9.2 from comm-central
(NoC192SM)
: Error out on building SeaMonkey with 1.9.2 from comm-central
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
: -- major (vote)
: seamonkey2.1a1
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
Depends on:
Blocks: C192ConfSync 511884 511896 521624 522712 536374 538753 540470 541723 545534 546487 547039 547375 549293
  Show dependency treegraph
 
Reported: 2010-02-16 12:43 PST by Robert Kaiser (not working on stability any more)
Modified: 2010-04-15 20:43 PDT (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Just error out (1.11 KB, patch)
2010-02-16 18:35 PST, Serge Gautherie (:sgautherie)
no flags Details | Diff | Review
(Av2) Just error out [Checkin: Comment 5] (882 bytes, patch)
2010-02-17 09:27 PST, Serge Gautherie (:sgautherie)
kairo: review+
Details | Diff | Review

Description Robert Kaiser (not working on stability any more) 2010-02-16 12:43:54 PST
As we decided to unsupport 1.9.2 for SeaMonkey on comm-central, we should error out on building with 1.9.2 from that tree, so people do not end up with broken, unsupported configurations inadvertently.
Comment 1 Serge Gautherie (:sgautherie) 2010-02-16 18:35:23 PST
Created attachment 427258 [details] [diff] [review]
(Av1) Just error out
Comment 2 Robert Kaiser (not working on stability any more) 2010-02-17 05:25:29 PST
Comment on attachment 427258 [details] [diff] [review]
(Av1) Just error out

> # Now is a good time to test for logic errors, define mismatches, etc.
> case "$MOZ_BUILD_APP" in
> xulrunner)
>   if test "$LIBXUL_SDK"; then
>     AC_MSG_ERROR([Building XULRunner --with-libxul-sdk doesn't make sense; XULRunner provides the libxul SDK.])
>   fi
>   ;;
>-esac

Don't join those case statements, they are for different reasons, as the comments explain. I wonder if building XULRunner from comm-central makes any sense at all, actually, but that's a different bug.

> # Special cases where we need to AC_DEFINE something. Also a holdover for apps
> # that haven't made a confvars.sh yet. Don't add new stuff here, use
> # MOZ_BUILD_APP.
>-case "$MOZ_BUILD_APP" in
> suite)
>+  if test "$MOZILLA_1_9_2_BRANCH" = "1"; then
>+    AC_MSG_ERROR([Building SeaMonkey with mozilla1.9.2 is not supported.])
>+  fi
>   AC_DEFINE(MOZ_SUITE)
>   ;;
>-
> mail)
>   AC_DEFINE(MOZ_THUNDERBIRD)
>   ;;
>-
> calendar)
>   AC_DEFINE(MOZ_SUNBIRD)
>   ;;
>-
> esac

Please leave those newlines in.

Also, did you try if we can do this in confvars.sh? If it works, I'd prefer that. The whole block of AC_DEFINEs here should actually go away at some stage, if possible...
Comment 3 Serge Gautherie (:sgautherie) 2010-02-17 09:27:31 PST
Created attachment 427354 [details] [diff] [review]
(Av2) Just error out
[Checkin: Comment 5]

Av1, with comment 2 suggestion(s).

(In reply to comment #2)

> I wonder if building XULRunner from comm-central makes any
> sense at all, actually, but that's a different bug.

Yeah, I thought about it too in the meantime... ;-)

> Also, did you try if we can do this in confvars.sh?

configure executes |. "${srcdir}/${MOZ_BUILD_APP}/confvars.sh"|.
I have no idea how to error out (from) there.

> The whole block of AC_DEFINEs here should actually go away at some stage,

Does it really matter for this ("short lived") code?
Comment 4 Robert Kaiser (not working on stability any more) 2010-02-17 09:52:31 PST
Comment on attachment 427354 [details] [diff] [review]
(Av2) Just error out
[Checkin: Comment 5]

Yes, I don't completely love it, but let's just do it.
Comment 5 Serge Gautherie (:sgautherie) 2010-02-17 10:28:48 PST
Comment on attachment 427354 [details] [diff] [review]
(Av2) Just error out
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/0cdce605ea0c

Note You need to log in before you can comment on or make changes to this bug.