546616 - Modify https.js to support web socket protocol or create a new server for the protocol

Status: RESOLVED DUPLICATE of bug 570789

(Testing :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Wellington Fernando de Macedo]

If you want, I can provide the hack I've done some time ago in the bug 472529, at <https://bugzilla.mozilla.org/attachment.cgi?id=380454&action=diff>. Then we could write mochitests for WebSockets. 

In this mean while, someone else could setup an entire functional ws server, what do you think about?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #1)
> If you want, I can provide the hack I've done some time ago in the bug 472529,
> at <https://bugzilla.mozilla.org/attachment.cgi?id=380454&action=diff>. Then we
> could write mochitests for WebSockets. 
Having at least some tests for websockets is a must.

> In this mean while, someone else could setup an entire functional ws server,
> what do you think about?
That would be useful too, but it is even more critical to have automated tests.
For simple manual testing http://www.websockets.org/ might be good enough (if it works, haven't tried yet).
To test protocol handling there should be tests also for invalid frames and
binary frames etc.

Comment 3

[Wellington Fernando de Macedo]

Attachment: my hack on httpd.js

It is my hack that makes httpd.js to support websockets. I've provided a very simple mochitest testing it. This patch should be applied on the last #472529 patch.

Wellington

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Any help here would be great.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Jeff, would a patch like attachment 429815 [details] [diff] [review] be ok for httpd.js?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Is this attachment a diff on mozilla-central automation.py?  Currently we have this setup to allow for dynamic web server and ports:
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in

Also on mozilla-central, we have changed localhost to be mochi.test:
https://elvis314.wordpress.com/2010/02/26/more-info-on-the-localhost-mochi-test-change/

Comment 7

[Wellington Fernando de Macedo]

(In reply to comment #6)
> Is this attachment a diff on mozilla-central automation.py?  Currently we have
> this setup to allow for dynamic web server and ports:
> http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in
Yes, it is too. I had to change it because I needed to bind the ws scheme in the tunnel that the sslproxy performs (even when not using ssl).

> Also on mozilla-central, we have changed localhost to be mochi.test:
> https://elvis314.wordpress.com/2010/02/26/more-info-on-the-localhost-mochi-test-change/
hmm, well, if you choose to use this patch for ws testing instead of forking httpd.js I can update.