546847 - Bad flags for WinMo builds

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Nicholas Nethercote [inactive]]

WinMo builds in the Tracemonkey repo have been failing recently.  This is because of a recently added file nanojit/njcpudetect.h which does a compile-time test of the ARM arch number.  AIUI njcpudetect.h is ok, but insufficient flags are being passed to the compiler at compile-time.

Crowder investigated and concluded that running "make CXXFLAGS=-QRarch5t" worked.  Therefore he thinks that configure.in needs to be modified so that -QRarch5t is passed to the C++ compiler.

The above-mentioned assertion is currently commented out so that TM builds on WinMo, but that's a temporary hack, this bug will provide the real fix.

It's also possible that the wrong flags have been used for WinMo builds all along?  Not sure about that.

Comment 1

[Brian Crowder]

Somehow js/src isn't getting magic from anything like this in my mozconfig:

mk_add_options MOZ_BUILD_PROJECTS="xulrunner mobile"
export OS_CFLAGS="-GL -QRarch5t -DARMV5"
mk_add_options OS_CFLAGS="-GL -QRarch5t -DARMV5"
export OS_CXXFLAGS="-GL -QRarch5t -DARMV5"

This bug needs to parallel the progress of Nicholas' work on merging recent nanojit-central changes into the tracemonkey repository, so it should block something.  Since there's no bug on that merge-work, I'm not sure what.

Comment 2

[Nicholas Nethercote [inactive]]

(In reply to comment #1)
> 
> This bug needs to parallel the progress of Nicholas' work on merging recent
> nanojit-central changes into the tracemonkey repository, so it should block
> something.  Since there's no bug on that merge-work, I'm not sure what.

Bug 542133 introduced the code that exposed this problem.

When this bug is fixed, the tracemonkey build problems will be fixed.  So there's no need for a separate bug.

Comment 3

[(not currently active) Ted Mielczarek]

crowder: OS_C[XX]FLAGS are set unconditionally in the build system:
http://mxr.mozilla.org/mozilla-central/source/config/autoconf.mk.in#285
from the values of C[XX]FLAGS from configure. You can insert your own values by doing:
export CFLAGS="foo"
in your mozconfig. This gets the values to configure, which inserts them into autoconf.mk.

Comment 4

[Brian Crowder]

export CFLAGS="-GL -QRarch5t -DARMV5"
mk_add_options CFLAGS="-GL -QRarch5t -DARMV5"
export CXXFLAGS="-GL -QRarch5t -DARMV5"
mk_add_options CXXFLAGS="-GL -QRarch5t -DARMV5"

This is working now, thanks Ted.  Still, I think we should be setting these in configure, rather than in mozconfig, since we now actually -require- ARMv5 to build.

Comment 5

[Nicholas Nethercote [inactive]]

Ted, that's good to know, but it doesn't fix the build problems.  Does the mozconfig used for the WinMo test machines need to be modified to add the 'export CFLAGS=' line?

Comment 6

[(not currently active) Ted Mielczarek]

No, we should just pick the right flags in configure, as crowder suggests. I'd be happy to review a patch.

Comment 7

[Nicholas Nethercote [inactive]]

Is this bug relevant any more?

Comment 8

[Nicholas Nethercote [inactive]]

AFAIK WinMo is no longer of interest to Mozilla.  Closing.  Please reopen if I'm wrong.