547063 - nanojit: reinstate NJ_COMPILER_ARM_ARCH static assertion in njconfig.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Nicholas Nethercote [inactive]]

I disabled this assertion in njconfig.cpp:

  NanoStaticAssert(NJ_COMPILER_ARM_ARCH >= 5 && NJ_COMPILER_ARM_ARCH <= 7);

because it was failing in the TM tree on WinMo due to a compiler misconfiguration (see bug 546847) and this was blocking all other NJ work.  Once that is fixed, the assertion should be re-enabled.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: patch

Mozilla doesn't do WinMo builds any more.  I'd like to land this.  If anything breaks, I can back it out again.

Comment 2

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/projects/nanojit-central/rev/b0decf655268
http://hg.mozilla.org/tracemonkey/rev/a871b845d417

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to comment #2)
> http://hg.mozilla.org/projects/nanojit-central/rev/b0decf655268

Sorry, that should be http://hg.mozilla.org/projects/nanojit-central/rev/04f1b105cccd

Comment 4

[Tamarin Bot]

changeset: 6082:3560a3866cba
user:      Nicholas Nethercote <[e-mail]>
summary:   Bug 547063 - nanojit: reinstate NJ_COMPILER_ARM_ARCH static assertion in njconfig.cpp.  r=rreitmai.

http://hg.mozilla.org/tamarin-redux/rev/3560a3866cba

Comment 5

[Nicholas Nethercote [inactive]]

Bug UntangleFrontEnd