nanojit: reinstate NJ_COMPILER_ARM_ARCH static assertion in njconfig.cpp

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
I disabled this assertion in njconfig.cpp:

  NanoStaticAssert(NJ_COMPILER_ARM_ARCH >= 5 && NJ_COMPILER_ARM_ARCH <= 7);

because it was failing in the TM tree on WinMo due to a compiler misconfiguration (see bug 546847) and this was blocking all other NJ work.  Once that is fixed, the assertion should be re-enabled.
(Assignee)

Updated

7 years ago
Depends on: 546847
(Assignee)

Comment 1

6 years ago
Created attachment 516768 [details] [diff] [review]
patch

Mozilla doesn't do WinMo builds any more.  I'd like to land this.  If anything breaks, I can back it out again.
Attachment #516768 - Flags: review?(edwsmith)

Updated

6 years ago
Attachment #516768 - Flags: review?(edwsmith) → review?(rreitmai)

Updated

6 years ago
Attachment #516768 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/b0decf655268
http://hg.mozilla.org/tracemonkey/rev/a871b845d417
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> http://hg.mozilla.org/projects/nanojit-central/rev/b0decf655268

Sorry, that should be http://hg.mozilla.org/projects/nanojit-central/rev/04f1b105cccd

Comment 4

6 years ago
changeset: 6082:3560a3866cba
user:      Nicholas Nethercote <nnethercote@mozilla.com>
summary:   Bug 547063 - nanojit: reinstate NJ_COMPILER_ARM_ARCH static assertion in njconfig.cpp.  r=rreitmai.

http://hg.mozilla.org/tamarin-redux/rev/3560a3866cba
Depends on: 670323
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Bug UntangleFrontEnd
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.