547497 - configure.in: don't rebuild WinCE tools in m-c when c-c has already done it

Status: VERIFIED WONTFIX

(Firefox Build System :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

I know nothing about WinCE,
but I wonder if adding a "if topsrcdir = mozilla" in m-c would be "wanted"?

Comment 1

[Justin Wood (:Callek)]

as a c-c peer; I prefer WONTFIX for this. For three reasons:

1) depending on c-c build system to do it right, in m-c is probably the wrong idea [though we try to stay up to date, and actually do it right; doesn't _always_ happen]
2) when m-c enters the dir; even if c-c did it already, nothing will be rebuilt unless it needs to, per normal Makefile behavior.
3) c-c doesn't yet have any supported app for winCE anyway.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)

My point of view:

> 1) depending on c-c build system to do it right, in m-c is probably the wrong
> idea [though we try to stay up to date, and actually do it right; doesn't
> _always_ happen]

I concur that c-c may not (always) be up-to-date and that's why I prefer to be consistent:
the tools shouldn't change "in the middle" of a c-c build.

> 2) when m-c enters the dir; even if c-c did it already, nothing will be rebuilt
> unless it needs to, per normal Makefile behavior.

I assume so too: yet still a (small) build time (etc) win.

> 3) c-c doesn't yet have any supported app for winCE anyway.

Chicken and egg: c-c maintains/wants WinCE support (already).

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

I assume you're talking about the fact the we build a temporary set of the tools to use for configure's AC_TRY_COMPILE and AC_TRY_LINK. I'm not sure what change you're actually proposing though.

We'd like to eliminate the tool wrappers entirely; unfortunately, NSS's build system is in the way. The patch on bug 462390 works, but will need some love in order to get landed in NSS.  I won't have time to work on that in the foreseeable future, but would appreciate someone picking up the ball and running with it.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)

> I assume you're talking about the fact the we build a temporary set of the
> tools to use for configure's AC_TRY_COMPILE and AC_TRY_LINK. I'm not sure what

Yes (though I don't know the details).

> change you're actually proposing though.

To skip this 'make' call when mozilla-central is built as part of a comm-central build.

> The patch on bug 462390 works
> would appreciate someone picking up the ball and running with it.

(Good. Not me.)

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

> To skip this 'make' call when mozilla-central is built as part of a
> comm-central build.

to avoid building the tools a second time in configure, I'd suggest checking to to see if CC, LD, AS, etc are set prior to building the temporary tools, because if they are (i.e. passed in from c-c's configure) we don't need to rebuild them.

this would of course only be a stop gap until we get bug 462390 resolved

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-MC) Add --disable-building-wince-tools option [Superseded by bug 648866]

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CC) Use --disable-building-wince-tools option [Useless without Av1-MC]

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 428098 [details] [diff] [review]
(Av1-MC) Add --disable-building-wince-tools option
[Superseded by bug 648866]

this is more Ted's department

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 428099 [details] [diff] [review]
(Bv1-CC) Use --disable-building-wince-tools option
[Useless without Av1-MC]

given c#1 I'm canceling review. if Ted wants to take for m-c then I'll re-look.

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 428098 [details] [diff] [review]
(Av1-MC) Add --disable-building-wince-tools option
[Superseded by bug 648866]

We don't want or need configure options for obscure things like this. Brad gave you a suggestion in comment 5, why didn't you implement that?

Comment 11

[Ed Morley [:emorley]]

WinCE/Windows Mobile support has been removed from the main build system, Spidermonkey, mobile installer, in-app updater and so on (see bug 614720, bug 554087 and all their dependants). Until such point where MS decide to release a Windows Phone 7 NDK and the decision is made to port to that platform, this is WONTFIX.

Filter bugmail on WinCEMassWONTFIX.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 428098 [details] [diff] [review]
(Av1-MC) Add --disable-building-wince-tools option
[Superseded by bug 648866]

Bug 648866 removed (all) this code.

Comment 13

[Serge Gautherie (:sgautherie)]

V.WontFix