54750 - Remove the space between 'To' field and the address.

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[Suresh]

Bring up the compose window and type in an address. Notice the space between 
'to' and the address. 

Build used: Today's BRANCH builds on all platforms.

Note:
1. I'm in Modern skin.
2. I will attach a screenshot. save as MS word file.

Comment 1

[Suresh]

Attachment: attached a screen shot.

Comment 2

[Jean-Francois Ducarroz]

Also not that the address icon is missing in modern skin.

reassign to Ben which break that! Should we fix that for rtm?

Comment 3

[esther]

Nominating rtm, this is a very visible window for mail and it's embarassing.

Comment 4

[esther]

removing my rtm nomination per rtm criteria review

Comment 5

[scottputterman]

reassigning to ducarroz to look into.

Comment 6

[Joe Hewitt (gone)]

*** Bug 55017 has been marked as a duplicate of this bug. ***

Comment 7

[Suresh]

will this make UI look better?
Compose window displays an 'address icon' for a single address and display a 
'mailing list icon' for a mailing list in the address.  (4.x doesn't support 
this)

Comment 8

[Jean-Francois Ducarroz]

Joe has the fix for it. Please attach the patch to this bug report.

Comment 9

[Joe Hewitt (gone)]

I'm about to attach a patch.  This patch contains the following fixes:

1. removes the large space between 'To' menulist and address textfield.
2. puts back the person icon
3. prevents addressingWidgetTree from stealing focus, so you can tab from the 
address to subject field (see bug #49232)
4. prevents the treerow from changing background color when clicked

All in all it makes this look the way it should.  Note that I set the box that 
contains the icon and textfield to autostretch="never" to prevent the textfield 
from being stretched (by the menulist) which prevents the text from lining up 
with the icon.  

Comment 10

[Joe Hewitt (gone)]

Attachment: patch with fixes as described above

Comment 11

[Jean-Francois Ducarroz]

r=ducarroz. I applied the patch and tested it in Classic & Modern. appart two 
little detail Joe already fixed, it works fine.

Comment 12

[Joe Hewitt (gone)]

Attachment: final patch, works for classic and modern

Comment 13

[Jean-Francois Ducarroz]

again, r=ducarroz for the second patch proposal

Comment 14

[scottputterman]

that's fantastic.  Can you get a super review and then bring it to pdt's attention?

Comment 15

[Joe Hewitt (gone)]

The patch is r=ducarroz, sr=alecf.

Comment 16

[hangas]

Marking rtm+

Comment 17

[Michael La Guardia]

marking rtm++

Comment 18

[Joe Hewitt (gone)]

Fixed.

Comment 19

[fenella]

Linux (2000-10-10-10 MN6)
Win32 (2000-10-10-09 MN6)
Mac  (2000-10-10-10 MN6)
This problem has been fixed.
I am not sure if we need to check it in the trunk.  Add vtrunk just in case

Comment 20

[esther]

putting vtrunk in keywords taking it out of Status whiteboard

Comment 21

[Asa Dotzler [:asa]]

Verified Fixed on trunk builds classic and modern themes.
linux 101808 RedHat 6.2
win32 101804 NT 4
mac 101804 Mac OS9
Setting bug to Verified and removing vtrunk keyword