547653 - Build toolkit search based on a define rather than an exclusion of some apps

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

One of several ways I accidentally stalled bug 526333 - it needs an ifdef for whether toolkit/components/search/ was built, and really, the existing "if it ain't Thunderbird or SeaMonkey" way of deciding isn't terribly pretty, or terribly convenient if an out-of-tree app doesn't want to build it.

Yes, I'm cheating a little, since a strict translation of the current state would be to default it to 1, and unset it in mail/confvars.sh and suite/confvars.sh, but then I'd have to do simultaneous pushes, and as you may have heard, "Having to ... get reviews from each app is a PITA." I will if I have to, but I'd rather not.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> but then I'd have to do simultaneous pushes

Would you? I don't think building this stuff would *break* thunderbird/seamonkey, so as a temporary state that should be fine, right?

I'd rather fix this the right way, rather than force any future consumers to have to somehow know about this.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.2

Indeed. And if I'd been cunning enough to have not mentioned review, I could just pretend I didn't think that confvars.sh changes to adapt to m-c changes called for review at all.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Unset it for Tb/SM

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 428269 [details] [diff] [review]
Fix v.2

Please don't add the actual MOZ_ARG_DISABLE_BOOL(). You just want the var for confvars.sh, you don't need the configure arg. There's no reason any normal person would want to flip this value.

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Fix v.3

/me resists the temptation to wield that policy-hammer against the other things in the same neighborhood and in the same class, which is pretty much all of them

Comment 6

[(not currently active) Ted Mielczarek]

We've already got bug 516758 on file (and Mitch already removed a bunch in bug 513924). It's a good thing, yes, but let's stay focused and at least not make the problem worse!

Comment 7

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/30e8d17cbe6b
http://hg.mozilla.org/comm-central/rev/499380d8c492