548217 - Solve lots of NP_SEEK stream problems

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benjamin Smedberg]

There are some very strange problems with NP_SEEK streams:

* Calling NPN_RequestRead crashes if the stream has already delivered all its data
* NPP_DestroyStream is never called on NP_SEEK streams

Lots of ownership refactoring was required to get this right, but I think I've done it.

Comment 1

[Benjamin Smedberg]

Attachment: Hold seekable streams alive correctly, rev. 1

The commit message/header of the patch has details.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/f829f942873d

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

For future reference, what did this bug affect? All plugins using NP_SEEK? Does that include Flash?

Comment 4

[Benjamin Smedberg]

I don't think we know which plugins use NP_SEEK. The only one I've seen is acrobat (and of course our testplugin tests), but that doesn't mean that in some special case flash couldn't use seekable streams.

Comment 5

[Benjamin Smedberg]

Backed out again because of topcrash bug 549112. Something about mLocalCachedFile is incorrect... *probably* the assignment at http://hg.mozilla.org/mozilla-central/annotate/4e1b68ecf126/modules/plugin/base/src/nsPluginHost.cpp#l830 which single-refcounts the member, but AFAICT the code is doing magic with last-release which means it should be *double* addrefed.

Comment 6

[Benjamin Smedberg]

Attachment: Share responsibility for deleting nsPluginStreamListenerPeer.mLocalCachedFile, rev. 1

Comment 7

[Benjamin Smedberg]

Whoops, landed a while back:
http://hg.mozilla.org/mozilla-central/rev/9c8823185edb
http://hg.mozilla.org/mozilla-central/rev/e050d3eaf1dd

Comment 8

[Benjamin Smedberg]

http://hg.mozilla.org/projects/firefox-lorentz/rev/c27ba5ce0dbf
http://hg.mozilla.org/projects/firefox-lorentz/rev/007077790db7

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 10

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430