Closed
Bug 548217
Opened 14 years ago
Closed 13 years ago
Solve lots of NP_SEEK stream problems
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(status1.9.2 .4-fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .4-fixed |
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
(Whiteboard: [fixed-lorentz])
Attachments
(2 files)
40.34 KB,
patch
|
jaas
:
review+
jst
:
review+
|
Details | Diff | Splinter Review |
17.59 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
There are some very strange problems with NP_SEEK streams: * Calling NPN_RequestRead crashes if the stream has already delivered all its data * NPP_DestroyStream is never called on NP_SEEK streams Lots of ownership refactoring was required to get this right, but I think I've done it.
Assignee | ||
Comment 1•14 years ago
|
||
The commit message/header of the patch has details.
Attachment #428664 -
Flags: review?(jst)
Attachment #428664 -
Flags: review?(joshmoz)
Attachment #428664 -
Flags: review?(joshmoz) → review+
Updated•14 years ago
|
Attachment #428664 -
Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/f829f942873d
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
For future reference, what did this bug affect? All plugins using NP_SEEK? Does that include Flash?
Assignee | ||
Comment 4•14 years ago
|
||
I don't think we know which plugins use NP_SEEK. The only one I've seen is acrobat (and of course our testplugin tests), but that doesn't mean that in some special case flash couldn't use seekable streams.
Assignee | ||
Comment 5•14 years ago
|
||
Backed out again because of topcrash bug 549112. Something about mLocalCachedFile is incorrect... *probably* the assignment at http://hg.mozilla.org/mozilla-central/annotate/4e1b68ecf126/modules/plugin/base/src/nsPluginHost.cpp#l830 which single-refcounts the member, but AFAICT the code is doing magic with last-release which means it should be *double* addrefed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•13 years ago
|
||
Attachment #430867 -
Flags: review?(joshmoz)
Attachment #430867 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Whoops, landed a while back: http://hg.mozilla.org/mozilla-central/rev/9c8823185edb http://hg.mozilla.org/mozilla-central/rev/e050d3eaf1dd
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/projects/firefox-lorentz/rev/c27ba5ce0dbf http://hg.mozilla.org/projects/firefox-lorentz/rev/007077790db7
Whiteboard: [fixed-lorentz]
Comment 9•13 years ago
|
||
Blanket approval for Lorentz merge to mozilla-1.9.2 a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed
Assignee | ||
Comment 10•13 years ago
|
||
Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430
status1.9.2:
--- → .4-fixed
Updated•1 year ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•