548228 - Port Bug 528776 [getBrowserState considers closed windows as open] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

From parent bug, this also can be the reason that some of tests failing:

Two things happened before this started:

http://hg.mozilla.org/mozilla-central/rev/4f62c9d94957
browser_477657.js, seems to open only one window?

http://hg.mozilla.org/mozilla-central/rev/01adc20ea792
browser_526613.js, backed out already

http://hg.mozilla.org/mozilla-central/rev/fa212b6a9d72
browser_394759.js

Comment 1

[Misak Khachatryan]

Attachment: patch plus test v1

Comment 2

[[e-mail]]

Comment on attachment 428673 [details] [diff] [review]
patch plus test v1

>diff --git a/suite/common/tests/browser/Makefile.in b/suite/common/tests/browser/Makefile.in
>--- a/suite/common/tests/browser/Makefile.in
>+++ b/suite/common/tests/browser/Makefile.in
>@@ -55,6 +55,7 @@ _BROWSER_FILES = \
> 	browser_bug524371.js \
> 	browser_bug524371_sample.html \
> 	browser_bug548211.js \
>+        browser_bug548228.js \
> 	$(NULL)
Nit: spaces where the other lines have a tab.

Comment 3

[Misak Khachatryan]

Attachment: for checkin

Nit fixed, carrying forward r+ and sr+ from Neil

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 428688 [details] [diff] [review]
for checkin

>+  _handleClosedWidnows: function sss_handleClosedWidnows() {

Not "handleClosedWi_nd_ows"? (everywhere)

Comment 5

[Misak Khachatryan]

Attachment: for checkin, syntax error corrected

Sorry, fixed, carrying forward r+ and sr+ from Neil

Comment 6

[Serge Gautherie (:sgautherie)]

See bug 542946 comment 5 wrt the test name...

Comment 7

[Misak Khachatryan]

Attachment: same as above, renamed test files as agreed

same as above, renamed test files as agreed, carrying forward r+ sr+ from Neil, got approval for renaming on meeting over IRC.

Comment 8

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/466f577ff66d - thanks for your work!