The default bug view has changed. See this FAQ.

Port Bug 528776 [getBrowserState considers closed windows as open] to SeaMonkey

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.1a1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

3.82 KB, patch
Misak Khachatryan
: review+
Misak Khachatryan
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
From parent bug, this also can be the reason that some of tests failing:

Two things happened before this started:

http://hg.mozilla.org/mozilla-central/rev/4f62c9d94957
browser_477657.js, seems to open only one window?

http://hg.mozilla.org/mozilla-central/rev/01adc20ea792
browser_526613.js, backed out already

http://hg.mozilla.org/mozilla-central/rev/fa212b6a9d72
browser_394759.js
(Assignee)

Comment 1

7 years ago
Created attachment 428673 [details] [diff] [review]
patch plus test v1
Attachment #428673 - Flags: superreview?(neil)
Attachment #428673 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 428673 [details] [diff] [review]
patch plus test v1

>diff --git a/suite/common/tests/browser/Makefile.in b/suite/common/tests/browser/Makefile.in
>--- a/suite/common/tests/browser/Makefile.in
>+++ b/suite/common/tests/browser/Makefile.in
>@@ -55,6 +55,7 @@ _BROWSER_FILES = \
> 	browser_bug524371.js \
> 	browser_bug524371_sample.html \
> 	browser_bug548211.js \
>+        browser_bug548228.js \
> 	$(NULL)
Nit: spaces where the other lines have a tab.
Attachment #428673 - Flags: superreview?(neil)
Attachment #428673 - Flags: superreview+
Attachment #428673 - Flags: review?(neil)
Attachment #428673 - Flags: review+
(Assignee)

Comment 3

7 years ago
Created attachment 428688 [details] [diff] [review]
for checkin

Nit fixed, carrying forward r+ and sr+ from Neil
Attachment #428673 - Attachment is obsolete: true
Attachment #428688 - Flags: superreview+
Attachment #428688 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 428688 [details] [diff] [review]
for checkin

>+  _handleClosedWidnows: function sss_handleClosedWidnows() {

Not "handleClosedWi_nd_ows"? (everywhere)
(Assignee)

Comment 5

7 years ago
Created attachment 428697 [details] [diff] [review]
for checkin, syntax error corrected

Sorry, fixed, carrying forward r+ and sr+ from Neil
Attachment #428688 - Attachment is obsolete: true
Attachment #428697 - Flags: superreview+
Attachment #428697 - Flags: review+
See bug 542946 comment 5 wrt the test name...
(Assignee)

Comment 7

7 years ago
Created attachment 432100 [details] [diff] [review]
same as above, renamed test files as agreed

same as above, renamed test files as agreed, carrying forward r+ sr+ from Neil, got approval for renaming on meeting over IRC.
Attachment #428697 - Attachment is obsolete: true
Attachment #432100 - Flags: superreview+
Attachment #432100 - Flags: review+

Comment 8

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/466f577ff66d - thanks for your work!
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
(Assignee)

Updated

7 years ago
Blocks: 593681
You need to log in before you can comment on or make changes to this bug.