Closed Bug 542946 Opened 10 years ago Closed 10 years ago

[SeaMonkey 2.1] mochitest-browser-chrome: "browser_bug524365.js:60 - TypeError: tabState.disallow is undefined"

Categories

(SeaMonkey :: Session Restore, defect, major)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.1a1

People

(Reporter: sgautherie, Assigned: misak.bugzilla)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 2 obsolete files)

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1264733897.1264735493.11690.gz
Linux comm-central-trunk debug test mochitest-other on 2010/01/28 18:58:17
{
TEST-PASS | chrome://mochikit/content/browser/suite/common/tests/browser/browser_bug524365.js | Everything is allowed per default
JavaScript strict warning: chrome://mochikit/content/browser/suite/common/tests/browser/browser_bug524365.js, line 60: reference to undefined property tabState.disallow
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/common/tests/browser/browser_bug524365.js | Exception thrown at chrome://mochikit/content/browser/suite/common/tests/browser/browser_bug524365.js:60 - TypeError: tabState.disallow is undefined
}

NB: There are other "JavaScript strict warning" and "JavaScript error" before, which may (not) be related.
Summary: [SeaMonkey trunk] mochitest-chrome: "mailTestUtils.js, line 53: Cc['@mozilla.org/messenger/account-manager;1'] is undefined" → [SeaMonkey trunk] mochitest-browser-chrome: "browser_bug524365.js:60 - TypeError: tabState.disallow is undefined"
MacOSX too:
{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1266802005.1266803746.19182.gz
OS X 10.5 comm-central-trunk debug test xpcshell on 2010/02/21 17:26:45
}
OS: Linux → All
Hardware: x86 → All
Summary: [SeaMonkey trunk] mochitest-browser-chrome: "browser_bug524365.js:60 - TypeError: tabState.disallow is undefined" → [SeaMonkey 2.1] mochitest-browser-chrome: "browser_bug524365.js:60 - TypeError: tabState.disallow is undefined"
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → misak.bugzilla
Status: NEW → ASSIGNED
Attachment #428878 - Flags: superreview?(neil)
Attachment #428878 - Flags: review?(neil)
Comment on attachment 428878 [details] [diff] [review]
fix

[Not sure why you needed to check the number of browser windows for this test.]
Attachment #428878 - Flags: superreview?(neil)
Attachment #428878 - Flags: superreview+
Attachment #428878 - Flags: review?(neil)
Attachment #428878 - Flags: review+
this is from http://hg.mozilla.org/mozilla-central/rev/5b2432ac3325

It adds some debug info for bug 528776 or our equivalent Bug 548228
Keywords: checkin-needed
(In reply to comment #4)

> this is from http://hg.mozilla.org/mozilla-central/rev/5b2432ac3325

Don't we want to port the change(s) in the other tests too?

> It adds some debug info for bug 528776 or our equivalent Bug 548228

Which reminds me:
could you use/rename (all) our ported Session Restore tests to have the same name as the m-c ones?
It makes searching (bugzilla and mxr) and sync'ing easier.

You could add a comment in our tests if you want to remember in which bug you ported them, though I would think hg history is enough.

Thanks.
Depends on: 528776
 
> Don't we want to port the change(s) in the other tests too?
> 

I'm doing it in tests patch (bug 480109).

> 
> Which reminds me:
> could you use/rename (all) our ported Session Restore tests to have the same
> name as the m-c ones?
> It makes searching (bugzilla and mxr) and sync'ing easier.
> 
> You could add a comment in our tests if you want to remember in which bug you
> ported them, though I would think hg history is enough.
> 
> Thanks.

I initially didn't touch tests filenames and bug numbers, but Neil corrects me, so i'm using our bug numbers from that time. Neil's comment will be nice here.
(In reply to comment #6)
> Neil's comment will be nice here.

Neil agreed at last irc SeaMonkey meeting.
same as above, renamed test files as agreed, carrying forward r+ sr+ from Neil, got approval for renaming on meeting over IRC.
Attachment #428878 - Attachment is obsolete: true
Attachment #432096 - Flags: superreview+
Attachment #432096 - Flags: review+
Oops, sorry, forgot to edit Makefile. Here is proper one.

renamed test files as agreed, carrying forward r+ sr+ from Neil,
got approval for renaming on meeting over IRC.
Attachment #432096 - Attachment is obsolete: true
Attachment #432116 - Flags: superreview+
Attachment #432116 - Flags: review+
Pushed as http://hg.mozilla.org/comm-central/rev/b2694d9ceefc - thanks for your work!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
V.Fixed per tinderboxes.

*****

(In reply to comment #9)
> renamed test files as agreed

Actually, we need to get rid of the 'bug' part too (or add it to FF files),
otherwise, the situation is better, but mxr searches still find only 1 of the files :-(
Status: RESOLVED → VERIFIED
Attachment #432116 - Attachment description: proper patch → proper patch [Checkin: Comment 10]
You need to log in before you can comment on or make changes to this bug.