548253 - crash [@ RtlpWaitOnCriticalSection | RtlAddAccessAllowedAce | PR_Lock | PR_DestroyMonitor | nsSSLThread::requestPoll], going offline / online? [Vista]

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ RtlpWaitOnCriticalSection | RtlAddAccessAllowedAce | PR_Lock]
all 3.0 and 3.0.1, except for my 3.1b1pre

note, prior to 2009-11-18 16:07:48 PST  per bug 514505 this crash will show as [@ RtlpWaitOnCriticalSection]. It's not worth searching crash-stats for RtlpWaitOnCriticalSection prior to this date, because these crashes are all over the map, as you can see by http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=2&range_unit=weeks&query_search=signature&query_type=contains&query=RtlpWaitOnCriticalSection&build_id=&process_type=all&do_query=1 

bp-24b46bcf-e2fa-4e70-9abd-04b8e2100208 3.0.1 reporter writes "This crash always happens when switching from offline mode to online mode.". No other crashes found with comments.

I crashed early this morning. I did not explicitly attempt going offline ...
bp-b7fdb22e-615d-40cd-ae1e-8b6a22100224 3.1b1pre
0	ntdll.dll	RtlpWaitOnCriticalSection	
1	ntdll.dll	RtlAddAccessAllowedAce	
2	nspr4.dll	PR_Lock	nsprpub/pr/src/threads/combined/prulock.c:233
3	nspr4.dll	PR_DestroyMonitor	
4	thunderbird.exe	nsSSLThread::requestPoll	security/manager/ssl/src/nsSSLThread.cpp:386
5	thunderbird.exe	nsSSLIOLayerPoll	security/manager/ssl/src/nsNSSIOLayer.cpp:1961
6	nspr4.dll	_PR_MD_PR_POLL	nsprpub/pr/src/md/windows/w32poll.c:156
7	thunderbird.exe	nsSocketTransportService::Poll	netwerk/base/src/nsSocketTransportService2.cpp:355
8	thunderbird.exe	nsSocketTransportService::DoPollIteration	netwerk/base/src/nsSocketTransportService2.cpp:660
9	thunderbird.exe	nsSocketTransportService::OnProcessNextEvent	netwerk/base/src/nsSocketTransportService2.cpp:535
10	xpcom_core.dll	nsThread::ProcessNextEvent	xpcom/threads/nsThread.cpp:508
11	xpcom_core.dll	NS_ProcessPendingEvents_P	objdir-tb/mozilla/xpcom/build/nsThreadUtils.cpp:200
12	thunderbird.exe	nsSocketTransportService::Run	netwerk/base/src/nsSocketTransportService2.cpp:581
13	xpcom_core.dll	nsThread::ProcessNextEvent	xpcom/threads/nsThread.cpp:527
14	xpcom_core.dll	NS_ProcessNextEvent_P	objdir-tb/mozilla/xpcom/build/nsThreadUtils.cpp:250
15	xpcom_core.dll	nsThread::ThreadFunc	xpcom/threads/nsThread.cpp:254

Comment 1

[Wayne Mery (:wsmwk)]

do we need socorro to skip frames further than PR_Lock??

hard to say if same stack still exists.
but most of thunderbird crashes have the same stack

bp-eb22e88e-11d7-48a2-b58c-7345d2101229 Thunderbird, 
EXCEPTION_ACCESS_VIOLATION_WRITE
0x14
3 	thunderbird.exe 	nsServerSocket::OnMsgClose 	netwerk/base/src/nsServerSocket.cpp:113

more precisely
0	ntdll.dll	RtlpWaitOnCriticalSection	
1	ntdll.dll	RtlAddAccessAllowedAce	
2	nspr4.dll	PR_Lock	nsprpub/pr/src/threads/combined/prulock.c:233
3	thunderbird.exe	nsServerSocket::OnMsgClose	netwerk/base/src/nsServerSocket.cpp:113
4	thunderbird.exe	nsRunnableMethod<nsHTMLObjectElement,void>::Run	objdir-tb/mozilla/dist/include/nsThreadUtils.h:282
5	xpcom_core.dll	nsThread::ProcessNextEvent	xpcom/threads/nsThread.cpp:527 

================

firefox crashes mostly cite facebook, farmville, etc... like
bp-435aba19-c810-4602-be57-0a6d42101129 Firefox
EXCEPTION_ACCESS_VIOLATION_WRITE
0x20202034

bp-eea27617-98d0-44eb-bc8d-4dea82101219 
EXCEPTION_ACCESS_VIOLATION_WRITE
0x20202034
3	js3250.dll	js_SuspendThread	js/src/jslock.cpp:1108

Comment 2

[timeless]

you could choose to skip RtlpWaitOnCriticalSection/RtlAddAccessAllowedAce i suppose

Comment 3

[Wayne Mery (:wsmwk)]

about 5 crashes per release per month.
all vista

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Improved crash signature to make it clear that this bug is specific to the nsSSLThread, which was removed in the patch for bug 674147.