548485 - Stand-alone SVG files don't display in Tabsposé

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Back in bug 461927, Stuart fixed XML-based filetypes so that they displayed in Tabsposé.  Unfortunately, stand-alone SVG files now display as blank thumbnails on 1.9.2 (other XML-based documents, and SVG embedded in other documents, thumbnail OK).

Note that bug 461927 noted a problem with GetClientWidth, and that moved/changed in 1.9.2 (see bug 544712); perhaps that's related?

http://www.croczilla.com/bits_and_pieces/svg/samples/chem1/chem1.svg
http://upload.wikimedia.org/wikipedia/commons/c/c7/SVG.svg

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Switch to viewportSize as the fallback

I futzed around with this some, and basically all I was able to determine is that GeckoUtils::GetIntrinsicSize does indeed fail in this case.

It's unclear why this is getting reset to 0 inside GetIntrinsicSize (and/or what sort of nsIDOMNSElement we are getting that's causing us to return 0 in GIS).

We can paper-over this bug again by using the viewport size in these cases, rather than 1.  In that case, Stuart wanted to init the values to 0:

[5:08pm] smorgan: But I'd be okay with a change to init the values to 0, and have the 0 check cases use viewport

Comment 2

[Stuart Morgan]

Comment on attachment 506958 [details] [diff] [review]
Switch to viewportSize as the fallback

sr=smorgan, but please file a bug to investigate why GetIntrinsicSize is giving the wrong answer.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/0a345af355d0

(In reply to comment #2)
> sr=smorgan, but please file a bug to investigate why GetIntrinsicSize is giving
> the wrong answer.

Filed bug 630762 for that.