Closed Bug 548491 Opened 16 years ago Closed 16 years ago

this.userChangedOutgoingSocketType should be this._userChangedOutgoingSocketType

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set
normal

Tracking

(thunderbird3.0 .4-fixed)

RESOLVED FIXED
Thunderbird 3.1b2
Tracking Status
thunderbird3.0 --- .4-fixed

People

(Reporter: eagle.lu, Assigned: eagle.lu)

Details

Attachments

(1 file)

at line http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/emailWizard.js#1378 this.userChangedOutgoingSocketType should be this._userChangedOutgoingSocketType
Assignee: nobody → brian.lu
Attachment #428869 - Flags: review?(bwinton)
Comment on attachment 428869 [details] [diff] [review] patch [Checkin: Comment 4 & 5] This is fairly clearly a correct change. But, would you please include a test for it in your patch to bug 534588, so that we can still comply with the all-new-patches-have-tests policy? (And since it touches mailnews code, you'll also need to get a superreview from someone. Bienvenu or Standard8, perhaps.) Thanks, Blake.
Attachment #428869 - Flags: review?(bwinton) → review+
Attachment #428869 - Flags: superreview?(bugzilla)
(In reply to comment #2) > (From update of attachment 428869 [details] [diff] [review]) > This is fairly clearly a correct change. > > But, would you please include a test for it in your patch to bug 534588, so > that we can still comply with the all-new-patches-have-tests policy? ok,the test case is not ready yet. I'm still working on it. >
Attachment #428869 - Flags: superreview?(bugzilla) → superreview+
Keywords: checkin-needed
Attachment #428869 - Attachment description: patch → patch [Checkin: Comment 4]
Attachment #428869 - Flags: approval-thunderbird3.0.4?
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
Flags: in-testsuite?
Attachment #428869 - Flags: approval-thunderbird3.0.4? → approval-thunderbird3.0.4+
Attachment #428869 - Attachment description: patch [Checkin: Comment 4] → patch [Checkin: Comment 4 & 5]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: