Closed Bug 54860 Opened 26 years ago Closed 25 years ago

Linux-psm warning dialog hangs browser

Categories

(Core Graveyard :: Security: UI, defect, P3)

Product:
Core Graveyard
Component:
Security: UI
Version:
1.0 Branch
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: cls, Assigned: javi)

References

Details

(Keywords: crash, regression, Whiteboard: [dogfood-] [rtm++])

Attachments

(3 files)

Patch to fix PSM uI which causes Linux to hang.
1.19 KB, patch
Details | Diff | Splinter Review
New patch which uses WIN32 instead of XP_WIN32 (WIN32 seems to be the correct macro.)
1.18 KB, patch
Details | Diff | Splinter Review
New diff with brendan's suggestion incorporated.
1.18 KB, patch
Details | Diff | Splinter Review
If you go to a s/imap site whose hostname does not match the name on the certificate, psm/ssl/whatever generates a warning dialog so that you can continue to go onto the site or cancel the connection. In recent builds, that dialog is blank. The only way to dismiss the dialog is to hit the close button on the title bar. However, once you do that, the entire application is basically frozen. The UI appears to work fine (menus work, you can type in urls, etc) but if you actually try to go to another site, the browser just sits there.
Adding the fun keywords as this makes the mail portion of mailnews unusable for me.
Keywords: dogfood, regression, rtm
hmmm... this is certainly a hassle, as you can't visit sites that have certs not matching the host name. I don't think this is common, and so I'm marking this dogfood-minus (it should really not stop use of the browser). If there are in-house test sites where we have to deal with this, then I would up it to a plus. I'm adding the crash keyword, since "hanging the browser" is effectively a crash. I know we'll want this for rtm, so I'm adding the rtm-need-info. When you have a patch or repair ready to go, please change this to a [rtm+] to request the double plus (landing permission on the branch).
Keywords: crash
Whiteboard: [dogfood-][rtm need info]
this sounds like a psm issue and not an imap issue. cc'ing some re-enforcements.
step one for re-assigning this to psm.
Component: Networking - IMAP → Security: General
Product: MailNews → Browser
cc'ing pavlov who said he has some free rtm cycles. Maybe he can help figure out what's going on with the psm dialog.
Component: Security: General → Networking - IMAP
Product: Browser → MailNews
this time for real, re-assigning to psm component.
Assignee: mscott → mstoltz
Component: Networking - IMAP → Security: General
Product: MailNews → Browser
QA Contact: esther → czhang
Reassigning to Crypto.
Assignee: mstoltz → ddrinan
Component: Security: General → Security: Crypto
QA Contact: czhang → junruh
Confirmed. This regression happens at an untrusted CA site, and non-matching cert name sites. I see info in the dialog boxes, but I still cannot click through them. It looks like bug 46253 is getting worse.
*** Bug 55865 has been marked as a duplicate of this bug. ***
Removing [rtm need info]. This should be rtm++
Summary: psm warning dialog hangs browser → Linux-psm warning dialog hangs browser
Whiteboard: [dogfood-][rtm need info] → [dogfood-]
I see something similar. Except the fact the window does not come up as blank to me. For example - for a new web site certificate the first window comes up and when I click next the window goes blank after a while. Then on I have to close the window by doing a right click on the title bar. For a website with a mismatch in the name the window comes with all the contents , but when I click continue anyway nothing happens.
junruh, all bugs that we want to fix for rtm need [rtm need info] in the status whiteboard. When a fix is in hand and it is reviewed and super reviewed, then we remove the need info part and add rtm+. That's how it gets on the PDT radar to make it rtm++. Adding back the required rtm need info status text...
Whiteboard: [dogfood-] → [dogfood-] [rtm need info]
For me in mail I can use other mail servers, even ones that use s/imap but not the one that hangs.
Fix is good. r=ddrinan.
Nit: it would be clearer to use #ifdef WIN32 both times, instead of #ifndef the first and #ifdef the second. Serious question: what bug(s) does this hack work around? Please cite the bug numbers here and link them as dependencies, leaving this bug open so we can get a better fix on the trunk. The APIs are XP, and their impls should behave in an XP fashion. danm, do you know what's biting here? Fix the nit and update this bug with dependencies, and a=brendan@mozilla.org for trunk and branch landing of the short-term fix. /be
Depends on: 56677
a=brendan@mozilla.org. Thanks for filing the dependency bug. /be
a=brendan r=ddrinan, nominating for check-in.
Whiteboard: [dogfood-] [rtm need info] → [dogfood-] [rtm+]
rtm double plus. Please land on branch asap.
Whiteboard: [dogfood-] [rtm+] → [dogfood-] [rtm++]
*** Bug 56700 has been marked as a duplicate of this bug. ***
*** Bug 56598 has been marked as a duplicate of this bug. ***
Fix checked into trunk. Will check into branch when the branch opens up.
Assignee: ddrinan → javi
Fixed. Worksforme on the 101708 trunk build. Adding vbranch keyword.
Status: NEW → RESOLVED
Closed: 25 years ago
Keywords: vbranch
Resolution: --- → FIXED
javi - did you check this into the branch yet? Thanks.
Fix has been checked into branch.
*** Bug 56939 has been marked as a duplicate of this bug. ***
verified on the 10/18 branch build.
Status: RESOLVED → VERIFIED
Mass changing Security:Crypto to PSM
Component: Security: Crypto → Client Library
Product: Browser → PSM
Version: other → 2.1
Mass changing Security:Crypto to PSM
Product: PSM → Core
Version: psm2.1 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: