Closed Bug 548826 Opened 10 years ago Closed 10 years ago

Drop the !important from the button::-moz-inner-focus rule

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

In bug 532206 we moved some code into content.css so we could override some focus styles.

One of the rules, button::-moz-inner-focus, has an extra !important that is causes Fennec to fail a reftest:

http://mxr.mozilla.org/mozilla-central/source/layout/reftests/bugs/491180-1.html?force=1

The reference file for the test depends on the padding being "1px 3px" and the !important is causing it to be "1px 2px"

Removing the !important should be fine and fix the test.
Attached patch patchSplinter Review
Actually, it was the "0px" part that changed the sizes. Since we want to affectively hide the focus ring, this patch keeps the "1px" but uses "none transparent" to make it invisible.

This way the border has the same width, but the focus ring is not visible. This patch should have no visible difference to the user.
Assignee: nobody → mark.finkle
Attachment #430401 - Flags: review?(21)
pushed:
http://hg.mozilla.org/mobile-browser/rev/f68482f37bad
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.