54909 - Pop3 - folders in trash are still visible after emptying trash

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[Peter Adolphs]

Overview Description:
If the trash folder contains other folders and you press "Empty Trash" the
content of the trash folder will be deleted on disk but all the included
folders (but not the folders content) are still visible in the mail frontend.
Similar to Bug#23447.

Steps to Reproduce:
1. delete a folder with some mails in it
2. go to Trash and do "Empty Trash"

Actual Results:
The deleted folder is still visible. If you click to this folder the mouse
pointer changes to hourglass but nothing else happens.

Expected Results:
Trash folder should be completely empty.

Comment 1

[Scott MacGregor]

load balancing....

Comment 2

[jefft]

This is working for me on Imap. Is this pop3 or imap problem?

Comment 3

[jefft]

Looks like this is a front end rdf tree updating problem. The backend seems 
working correctly. The directory and subfolders were deleted as expected.

Comment 4

[jefft]

Scott, looks like nsMsgFolder::PropagateDelete() failed to remove subfolders 
from the folder view. By looking into the code, we seems doing the right thing. 
Recreating the Trash folder seems pull back the old folder view. Adding rtm and 
mailtrack keyword.

Comment 5

[jefft]

Selecting on delete subfolder causes the app to hang 5-10 seconds, pretty 
annoying. I think we should fix it for rtm.

Comment 6

[scottputterman]

The front end isn't being updated correctly. The breakpoint in the datasource is
never being hit.

Comment 7

[scottputterman]

the case I just mentioned below happened when my trash had no messages but did
have folders. In this case nothing happens because we have code that says to not
continue the operation if the trash has no messages. I think we need to look for
folders even if there are no messages. This is in nsLocalMailFolder::EmptyTrash.

Comment 8

[scottputterman]

In the case where I do have a message it doesn't work either.  It looks like
there are 4 remove notifications sent off to the front end.  If these are done
in a strange order then there's the possibility the front end is getting messed up.

Comment 9

[jefft]

Yup, I have fix for the empty sub folder case even though we have no messages we 
should perform the empty trash task.

Comment 10

[scottputterman]

marking rtm- under the assumption that the folders are really deleted and the 
next time you start up they aren't there.  

Comment 11

[esther]

Scott here's what I found with pr3 branch build on POP account the folders are
still there after exit and relaunch:
1.Delete (using Delete button) a folder that only has a subfolder. Empty Trash!
Still visible in trash.
a.) Exit and open app again the folders are still visible in Trash
b.) You can select this folder while in Trash and Click the delete button again
and it is removed.
Same results with a Folder w/msg scenario.
So you can get rid of the folder but not through Empty Trash.

Comment 12

[scottputterman]

*** Bug 48648 has been marked as a duplicate of this bug. ***

Comment 13

[scottputterman]

reassigning to naving.

Comment 14

[scottputterman]

*** Bug 56838 has been marked as a duplicate of this bug. ***

Comment 15

[Navin Gupta]

Attachment: Should fix it. Asking for review.

Comment 16

[scottputterman]

You don't need to go to all of this work to unregister the resource. You can 
just QI the child into an nsIRDFResource and then use the rdf service to 
unregister it.

Comment 17

[Navin Gupta]

*** Bug 60320 has been marked as a duplicate of this bug. ***

Comment 18

[R.K.Aa.]

*** Bug 60565 has been marked as a duplicate of this bug. ***

Comment 19

[(not reading, please use [e-mail] instead)]

adding myself the cc list.

I'm not comfortable with this fix yet.

naving and I have met and talked it over, but there is still some investigation
to do.

Comment 20

[Boris Zbarsky [:bzbarsky]]

*** Bug 62313 has been marked as a duplicate of this bug. ***

Comment 21

[Matthias Versen [:Matti]]

*** Bug 62313 has been marked as a duplicate of this bug. ***

Comment 22

[scottputterman]

nominating as mail3

Comment 23

[Matthias Versen [:Matti]]

*** Bug 63217 has been marked as a duplicate of this bug. ***

Comment 24

[(not reading, please use [e-mail] instead)]

naving and I talked about this on friday.

he's going to use the refcount balancer and see who has the reference on the
resource and see if we can fix the leak.

Comment 25

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8

Comment 26

[Sheela Ravindran]

change qa contact to myself

Comment 27

[Navin Gupta]

Fix checked in 

Comment 28

[Sheela Ravindran]

verified on buildid 2000122606 on all

Comment 29

[Boris Zbarsky [:bzbarsky]]

*** Bug 63866 has been marked as a duplicate of this bug. ***

Comment 30

[Boris Zbarsky [:bzbarsky]]

*** Bug 63866 has been marked as a duplicate of this bug. ***