549250 - Omnibus ad-blocking bug for March/April/May/June/July 2010

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Let there be no more ads or flashing banners…

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

From cl in follow-up to bug 543264 comment 6 and bug 543264 comment 7:

> http://ads.shorttail.net/cgi-bin/ads/ad17922k.cgi/v=2.3S/sz=1x1A/%27+rnum+%27/%27+nf+%27RETURN-CODE/JS/
> The Flash is embedded via that script

Comment 2

[philippe (part-time)]

On file-upload.net/ ugly ads blocking the download button. clicking the ad to dismiss (they have a windoze like close button on the right) launches a popup under window (empty when I tested).

http://www.file-upload.net/download-2341675/bug_blue_ring_location_bar.pdf.html

<div id="sponsorads46554" style="width: 802px ! important; height: 499px; position: fixed; left: 20px; top: 50px; display: block; background: none repeat scroll 0% 0% rgb(255, 255, 255); border: 1px solid rgb(240, 240, 240); z-index: 1000; margin-left: 11%;">

The number seems random.

--->> div[id^="sponsorads"]


Mehmet regularly links to that download site.

Comment 3

[Chris Lawson (gone)]

http://www.businessnorth.com/briefing.asp?RID=3434  has some ads along the right side. "pics/banners" or "banred" in the URL is the common identifier. Not sure if we can do anything about them or not that isn't either too specific or too generic.

Comment 4

[Chris Lawson (gone)]

Facebook photo pages are showing ads on the right now. (Most other pages on Facebook still don't show any ads.)

<div class="UIStandardFrame_SidebarAds">

is the relevant part, I think.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.telegraph.co.uk/technology/apple/7800676/10-reasons-not-to-buy-Apples-new-iPhone-4G.html

Either or both of:
 
# div class="googleads"
# div id="google-ads-container"

Comment 6

[philippe (part-time)]

http://www.publico.es/ has some (random) flash ads:

<embed src="http://publis-images.adbureau.net/publis/documentales_300x250_210410.swf?clickTag=http://publis.adbureau.net/accipiter/adclick/CID=00001075c25c1ea600000000/acc_random=770185/SITE=PUBLICO.ES/AREA=PUBLICO.HOME/POS=1/AAMSZ=300X250/VIS=/pageid=77530001" width="300" height="250" wmode="transparent" allowscriptaccess="always" type="application/x-shockwave-flash" swliveconnect="false" quality="autohigh" pluginspace="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash">

embed[src*="publis-images.adbureau.net"] deals with them

hmmm: http://adbureau.net redirects to http://www.atlassolutions.com/ which only shows a 1x1px gif file. maybe blocking on just adbureau.net is sane, given that name…

Low on that page, also some (animated) image banners that appear to be ads, but are hard to block. The only possibility: a.enlaceExterno, but I don't trust that: enlaceExterno means 'outside link' and is pretty generic.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #4)
> Facebook photo pages are showing ads on the right now. (Most other pages on
> Facebook still don't show any ads.)
> 
> <div class="UIStandardFrame_SidebarAds">
> 
> is the relevant part, I think.

and <div class="UIWashFrame_SidebarAds">, too.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On weather.com:

iframe class : OASAdFrame

Comment 9

[Chris Lawson (gone)]

Lots of ads here: http://thedenverdailynews.com/article.php?aID=8862

All the image names seem to start with "bannerad_".

Comment 10

[philippe (part-time)]

Noticed while analysing bug 573009

we have on line 349: iframe[src*="ad.doubleclick.net"],
and on line 367 iframe[src*="doubleclick"],
those could be consolidated I think (remove the first one)

(both have been there since the dawn of time, it looks like)

Comment 11

[Chris Lawson (gone)]

On http://articles.latimes.com/2010/jun/16/local/la-me-0616-sheen-car-20100616

div class="mod-adopenx"

Both a banner at the top and a block in the article itself.

cl

Comment 12

[philippe (part-time)]

Seen on http://www.dailymotion.com/video/x20sgq_led-zeppelin-whole-lotta-love_music

(if you use Flashblock, you first have to unblock the main movie then the ad loads as an horizontal banner)

<div class="dmco_box">
          <div class="dmpi_masscast">
            <div id="mc_Top" class="Top" style="height: 90px; "><iframe src="/middle?position=Top&amp;mandatoryJS=http%3A%2F%2Fak.style.dailymotion.com%2Fjs%2Fgen%2Fwidget%2Fpack%2Fmandatory.js.v119801306" scrolling="no" frameborder="0" allowtransparency="true" class="masscast" style="height: 90px; "></iframe></div>
          </div>
        </div>

The contents of the iframe was Jpn specific advertisement.

Comment 13

[Chris Lawson (gone)]

On http://www.bikeexif.com/1957-harley-panhead

img src="http://s3.buysellads.com"... etc
div class="sidebarAdBlock"

Both seem like legitimate things to block.

cl

Comment 14

[philippe (part-time)]

While investigating bug 580256,  I noticed some flash ads creeping through on http://www.tvsubtitles.net/. Those are coming from adreactor com

embed[type="application/x-shockwave-flash"][src*="adreactor.com/services/advertisements/]
Those that creep through are non-standard sizes.

Images from the same ad provider are already blocked (a:link[href*="adserver"] img, ). Some swf are blocked (based on size: 300x250).

Comment 15

[Chris Lawson (gone)]

(In reply to comment #1)
> From cl in follow-up to bug 543264 comment 6 and bug 543264 comment 7:
> 
> > http://ads.shorttail.net/cgi-bin/ads/ad17922k.cgi/v=2.3S/sz=1x1A/%27+rnum+%27/%27+nf+%27RETURN-CODE/JS/
> > The Flash is embedded via that script

Smokey said tonight he still couldn't reproduce this; I haven't seen it that I recall since I made the original comment on 24 February, and that was 2500+ NYTimes pages ago. I suspect they aren't doing it any more, so I guess this comment is CANTFIXWITHOUTCONCRETEEXAMPLE.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> http://www.businessnorth.com/briefing.asp?RID=3434  has some ads along the
> right side. "pics/banners" or "banred" in the URL is the common identifier. Not
> sure if we can do anything about them or not that isn't either too specific or
> too generic.

Yeah, I don't think there's anything we can do about those.

(In reply to comment #12)
> Seen on
> http://www.dailymotion.com/video/x20sgq_led-zeppelin-whole-lotta-love_music
[...]
> The contents of the iframe was Jpn specific advertisement.

philippe and I talked about this one, and there's no good way to block it, since the iframe shows up a lot without the class, and blocking parent elements leads to blocking content on the page.  Since the ads are blocked 100% of the time here, and 80% of the time for philippe, we're just going to drop it now.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Omnibus patch

Ahem.  This should handle everything from the last 5(!) months in here and in the bugs this blocks :-(

This also fixes bug 384729 (when Flashblock is also enabled, hide the Flashblock placeholder; mostly--some still escape, but this should be better by-and-large) and bug 512141 (blocking a few known Flash tracking "movies").

The deletions are comment 10 and then grouping all of the Google <div> rules together, instead of them being so scattered throughout that section.  The new override is to allow users to escape from the evil AdBrite "ispan"s that overlay pages (and break scrolling if blocked).

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Omnibus patch, now with more bug 567735

Ooops, I missed philippe confirming bug 567735.  So this is everything in comment 17 plus that rule.

Comment 19

[Stuart Morgan]

Comment on attachment 461998 [details] [diff] [review]
Omnibus patch, now with more bug 567735

sr=smorgan

Comment 20

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/1ee085041bf3

Although we want to take this for 2.0.4, I'll hold off on landing it there for a few days pending (lack of) feedback from nightly users.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on CAMINO_2_0_BRANCH in advance of 2.0.4; this way 2.0.4pre nightly users can also catch any possible regressions while we finish up the rest of the 2.0.4 stuff (and we'll either fix or just back out any problematic rules).