Port MOZ_IPC support to comm-central

RESOLVED FIXED in Thunderbird 3.1b2

Status

MailNews Core
Build Config
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({fixed-seamonkey2.0.5})

Trunk
Thunderbird 3.1b2
fixed-seamonkey2.0.5
Dependency tree / graph
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird3.0 .5-fixed)

Details

(URL)

Attachments

(5 attachments, 1 obsolete attachment)

Comment hidden (empty)

Comment 1

7 years ago
What is this bug supposed do that isn't covered by bug 545716? Are there core build system changes we need on our side?
Blocks: 545716
(Assignee)

Comment 2

7 years ago
This bug is to port c-c configure support that we ignored initially, but we'll need to support packaging.
Bug 545716 looks like a SeaMonkey "meta": blocking it is fine ;-)
(Assignee)

Updated

7 years ago
Assignee: nobody → sgautherie.bz

Comment 3

7 years ago
OK, good - if configure support is actually doing something. Not that it can really work with our non-libxul linking right now, but both SeaMonkey and Thunderbird want to go multi-process in the future (for SeaMonkey, the plugins-only stuff already helps).
A pointer to the original bug/changeset that is to be ported here is usually helpful in clearing up what such a bug means. ;-)
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)
> A pointer to the original bug/changeset that is to be ported here is usually
> helpful in clearing up what such a bug means. ;-)

... :-|

Look at http://dev.seamonkey.at/?d=x&i=mozilla&m=c:
most changesets had no bugs;
I'll list what I actually port when I do it.

Comment 5

7 years ago
Hrm, how I hate checkins without bugs. :(
(Assignee)

Updated

7 years ago
Target Milestone: Thunderbird 3.1rc1 → ---
(Assignee)

Updated

7 years ago
(Assignee)

Updated

7 years ago
Depends on: 523097
(Assignee)

Updated

7 years ago
Depends on: 515748
(Assignee)

Comment 6

7 years ago
Created attachment 431342 [details] [diff] [review]
(Av1) Just copy (the useful part of) it
[Checkin: See comment 10]
Attachment #431342 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 7

7 years ago
Created attachment 431353 [details] [diff] [review]
(Bv1-SM) Package mozilla-runtime@BIN_SUFFIX@, Do some list reorderings
Attachment #431353 - Flags: review?(bugspam.Callek)
Comment on attachment 431342 [details] [diff] [review]
(Av1) Just copy (the useful part of) it
[Checkin: See comment 10]

Looks good, but some notes:

Nit: Please mention that you also ported 848a7cf64d03 from m-c.

Also please port  the
|test -n "$MOZ_IPC" -a -z "$MOZ_ENABLE_LIBXUL"| as in changeset b4e0340c74be

Also please remove the block found by searching for: 
|dnl Disable libxul in debug builds.|
ala changeset db2c3e1c7d28.

r+ with those fixed.
Attachment #431342 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 431353 [details] [diff] [review]
(Bv1-SM) Package mozilla-runtime@BIN_SUFFIX@, Do some list reorderings

>+#ifdef MOZ_IPC
>+@BINPATH@/mozilla-runtime@BIN_SUFFIX@
>+#endif

This in particular looks good; but the re-orderings make this patch hard to decipher; please do them in another bug.

Also please patch the mail/* packages file for this.
Attachment #431353 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 10

7 years ago
Comment on attachment 431342 [details] [diff] [review]
(Av1) Just copy (the useful part of) it
[Checkin: See comment 10]


http://hg.mozilla.org/comm-central/rev/eca0ae9a6322
Av1, with comment 8 suggestion(s).

(In reply to comment #8)

> Nit: Please mention that you also ported 848a7cf64d03 from m-c.

It already is.

> Also please port  the
> |test -n "$MOZ_IPC" -a -z "$MOZ_ENABLE_LIBXUL"| as in changeset b4e0340c74be

As you want, though I find it redundant.

> Also please remove the block found by searching for: 
> |dnl Disable libxul in debug builds.|
> ala changeset db2c3e1c7d28.

Already ported by bug 506493 patch Bv1 ;->
Attachment #431342 - Attachment description: (Av1) Just copy (the useful part of) it. → (Av1) Just copy (the useful part of) it [Checkin: See comment 10]
(Assignee)

Updated

7 years ago
Depends on: 552190
(Assignee)

Comment 11

7 years ago
Created attachment 434293 [details] [diff] [review]
(Bv2-SM) Package mozilla-runtime@BIN_SUFFIX@, And remove @DLL_PREFIX@sqlite3@DLL_SUFFIX@ for all platforms
[Checkin: Comment 12]

Bv1-SM, with comment 9 suggestion(s).
Attachment #431353 - Attachment is obsolete: true
Attachment #434293 - Flags: review?(bugspam.Callek)

Updated

7 years ago
Attachment #434293 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 12

7 years ago
Comment on attachment 434293 [details] [diff] [review]
(Bv2-SM) Package mozilla-runtime@BIN_SUFFIX@, And remove @DLL_PREFIX@sqlite3@DLL_SUFFIX@ for all platforms
[Checkin: Comment 12]


http://hg.mozilla.org/comm-central/rev/5528d77d0a21
Attachment #434293 - Attachment description: (Bv2-SM) Package mozilla-runtime@BIN_SUFFIX@, And remove @DLL_PREFIX@sqlite3@DLL_SUFFIX@ for all platforms → (Bv2-SM) Package mozilla-runtime@BIN_SUFFIX@, And remove @DLL_PREFIX@sqlite3@DLL_SUFFIX@ for all platforms [Checkin: Comment 12]
(Assignee)

Comment 13

7 years ago
Comment on attachment 434293 [details] [diff] [review]
(Bv2-SM) Package mozilla-runtime@BIN_SUFFIX@, And remove @DLL_PREFIX@sqlite3@DLL_SUFFIX@ for all platforms
[Checkin: Comment 12]


Ftr, this ported changeset a8076123b234.
(Assignee)

Updated

7 years ago
Depends on: 546484
No longer depends on: 552190
(Assignee)

Comment 14

7 years ago
Created attachment 434521 [details] [diff] [review]
(Cv1-TB) Package mozilla-runtime@BIN_SUFFIX@, (m-1.9.2+)
[Checkin: Comment 15]
Attachment #434521 - Flags: review?(bugzilla)
Attachment #434521 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 15

7 years ago
Comment on attachment 434521 [details] [diff] [review]
(Cv1-TB) Package mozilla-runtime@BIN_SUFFIX@, (m-1.9.2+)
[Checkin: Comment 15]


http://hg.mozilla.org/comm-central/rev/d6ddf2133e05
Attachment #434521 - Attachment description: (Cv1-TB) Package mozilla-runtime@BIN_SUFFIX@, (m-1.9.2+) → (Cv1-TB) Package mozilla-runtime@BIN_SUFFIX@, (m-1.9.2+) [Checkin: Comment 15]
(Assignee)

Comment 16

7 years ago
Created attachment 435042 [details] [diff] [review]
(Dv1-SM-191) Support downgrading
[Checkin: See comment 18+20+21]
Attachment #435042 - Flags: review?(kairo)
Attachment #435042 - Flags: approval-seamonkey2.0.5?
(Assignee)

Comment 17

7 years ago
Created attachment 435044 [details] [diff] [review]
(Ev1-TB-191) Support downgrading
[Checkin: Comment 24]
Attachment #435044 - Flags: review?(bugzilla)
Attachment #435044 - Flags: approval-thunderbird3.0.5?
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2

Updated

7 years ago
Attachment #435042 - Flags: review?(kairo)
Attachment #435042 - Flags: review+
Attachment #435042 - Flags: approval-seamonkey2.0.5?
Attachment #435042 - Flags: approval-seamonkey2.0.5+
(Assignee)

Comment 18

7 years ago
Comment on attachment 435042 [details] [diff] [review]
(Dv1-SM-191) Support downgrading
[Checkin: See comment 18+20+21]


http://hg.mozilla.org/releases/comm-1.9.1/rev/9757cb0d1077
Attachment #435042 - Attachment description: (Dv1-SM-191) Support downgrading → (Dv1-SM-191) Support downgrading [Checkin: Comment 18]
(Assignee)

Updated

7 years ago
Keywords: fixed-seamonkey2.0.5

Comment 19

7 years ago
Comment on attachment 435042 [details] [diff] [review]
(Dv1-SM-191) Support downgrading
[Checkin: See comment 18+20+21]

This burned up the SeaMonkey2.0 trees:

__main__.Error: ('/builds/slave/comm-1.9.1-linux/build/suite/installer/removed-files.in', 119, 'UNDEFINED_VAR', 'BIN_SUFFIX')

If it's not fixed within 2 hours, I'll back it out there.
(Assignee)

Updated

7 years ago
Depends on: 496809
(Assignee)

Comment 20

7 years ago
Comment on attachment 435042 [details] [diff] [review]
(Dv1-SM-191) Support downgrading
[Checkin: See comment 18+20+21]


+
http://hg.mozilla.org/releases/comm-1.9.1/rev/d0389e0d9fad
(Fv1-SM-191) Bustage fix.

Sorry, I didn't know about bug 496809 :-<
Attachment #435042 - Attachment description: (Dv1-SM-191) Support downgrading [Checkin: Comment 18] → (Dv1-SM-191) Support downgrading [Checkin: See comment 18+20]
(Assignee)

Comment 21

7 years ago
Comment on attachment 435042 [details] [diff] [review]
(Dv1-SM-191) Support downgrading
[Checkin: See comment 18+20+21]


(In reply to comment #20)
> http://hg.mozilla.org/releases/comm-1.9.1/rev/d0389e0d9fad
> (Fv1-SM-191) Bustage fix.

http://hg.mozilla.org/releases/comm-1.9.1/rev/6d18fdf75302
Revert now unneeded '(Fv1-SM-191) Bustage fix' workaround.
Attachment #435042 - Attachment description: (Dv1-SM-191) Support downgrading [Checkin: See comment 18+20] → (Dv1-SM-191) Support downgrading [Checkin: See comment 18+20+21]
(In reply to comment #21)
> (From update of attachment 435042 [details] [diff] [review])
> 
> (In reply to comment #20)
> > http://hg.mozilla.org/releases/comm-1.9.1/rev/d0389e0d9fad
> > (Fv1-SM-191) Bustage fix.
> 
> http://hg.mozilla.org/releases/comm-1.9.1/rev/6d18fdf75302
> Revert now unneeded '(Fv1-SM-191) Bustage fix' workaround.

I don't see any note or comment on why this would be "now unneeded" I also note that this (again) burnt the 1.9.1 box. Please backout & explain why you felt it was "now unneeded" ?

Please seek r+ and a+ for a relanding.
(Assignee)

Comment 23

7 years ago
(In reply to comment #22)
> I don't see any note or comment on why this would be "now unneeded"

Sorry, forgot to push m-1.9.1 fix first :-<
Attachment #435044 - Flags: review?(bugzilla)
Attachment #435044 - Flags: review+
Attachment #435044 - Flags: approval-thunderbird3.0.5?
Attachment #435044 - Flags: approval-thunderbird3.0.5+
(Assignee)

Comment 24

7 years ago
Comment on attachment 435044 [details] [diff] [review]
(Ev1-TB-191) Support downgrading
[Checkin: Comment 24]


http://hg.mozilla.org/releases/comm-1.9.1/rev/4c78410873a4
Attachment #435044 - Attachment description: (Ev1-TB-191) Support downgrading → (Ev1-TB-191) Support downgrading [Checkin: Comment 24]
(Assignee)

Updated

7 years ago
status-thunderbird3.0: --- → .5-fixed
Comment on attachment 435044 [details] [diff] [review]
(Ev1-TB-191) Support downgrading
[Checkin: Comment 24]

Turns out landing this broke the Thunderbird3.0 boxes because they haven't picked up the BIN_SUFFIX fix that landed in c-1.9.1 post 3.0.4.

Therefore I've backed this out, and resetting approval request, and we'll land when we pick up the latest branch but before 3.0.5.
Attachment #435044 - Flags: approval-thunderbird3.0.5+ → approval-thunderbird3.0.5?
status-thunderbird3.0: .5-fixed → ---
Attachment #435044 - Flags: approval-thunderbird3.0.5? → approval-thunderbird3.0.5+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Whiteboard: [c-n: comment 25]
Re-landed: http://hg.mozilla.org/releases/comm-1.9.1/rev/b368f780a23f
status-thunderbird3.0: --- → .5-fixed
Keywords: checkin-needed
Whiteboard: [c-n: comment 25]
You need to log in before you can comment on or make changes to this bug.