Closed Bug 549390 Opened 11 years ago Closed 11 years ago

Package new layers library on shared builds

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.1a1

People

(Reporter: kairo, Assigned: sgautherie)

References

Details

(Keywords: fixed-seamonkey2.0.4)

Attachments

(1 file, 1 obsolete file)

After seeing that our packaged tests are broken and some bug 534425 comment claiming it should be backed out because of that, I decided to first take a look at more details. It felt somewhat strange that alive tests, malloc/laek and check tests were successful but builds failed to even start up for packaged tests, so I suspected a packaging issue.

In Linux package-compare, I found this file wasn't packaged:

bin/liblayers.so


I guess we need to package that file with its different names for every platform in shared builds, and that probably will fix the tests.

I need to leave quite soon today, but I wanted this filed so someone else can potentially make progress here.
Attached patch fix? (obsolete) — Splinter Review
Seems like the right thing to do, but I'm not sure if it will fix things.
Assignee: nobody → roc
Attachment #429576 - Flags: review?
http://hg.mozilla.org/comm-central/rev/7e6d3908a938
(Av1) Just package it
Assignee: roc → sgautherie.bz
Severity: normal → major
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Comment on attachment 429576 [details] [diff] [review]
fix?


Sorry, "Mid-air collision detected!"...
Attachment #429576 - Attachment is obsolete: true
Attachment #429576 - Flags: review?
Attachment #429580 - Flags: review?(kairo)
Attachment #429580 - Flags: approval-seamonkey2.0.4?
Attachment #429580 - Flags: review?(kairo)
Attachment #429580 - Flags: review+
Attachment #429580 - Flags: approval-seamonkey2.0.4?
Attachment #429580 - Flags: approval-seamonkey2.0.4+
(In reply to comment #2)
> http://hg.mozilla.org/comm-central/rev/7e6d3908a938
> (Av1) Just package it

Sorry, but in the future, please get a r= over IRC at least to actually do this. Should be easy to catch someone who can bless it and fixing somebody else's bustage without any blessing from anyone is not nice style.
That said, 1) thanks to both Rob and Serge for caring about it - and 2) Serge, the mail/ part of Rob's patch might still be relevant to Thunderbird folks!
(In reply to comment #5)

> Sorry, but in the future, please get a r= over IRC at least to actually do
> this. Should be easy to catch someone who can bless it and fixing somebody

Who? You wrote in comment 0 that you weren't available any longer...

> else's bustage without any blessing from anyone is not nice style.

Next time, just don't cc me and ask for someone else to take over!

NB: I'm so used to get all the blame for warning and fixing things when bustage author gets none :-(
Comment on attachment 429580 [details] [diff] [review]
(Bv1-191) Support downgrading
[Checkin: Comment 8]


http://hg.mozilla.org/releases/comm-1.9.1/rev/2660052256b3
Attachment #429580 - Attachment description: (Bv1-191) Support downgrading → (Bv1-191) Support downgrading [Checkin: Comment 8]
V.Fixed, per SM21 tinderboxes.
Status: RESOLVED → VERIFIED
When I build xulrunner or firefox, liblayers.so does not exist as a shared library.

I suppose liblayers.a is generated and it is combined to libxul.so for xulrunner/firefox.

Does bug 543159 fix this?
(In reply to comment #7)
> > Sorry, but in the future, please get a r= over IRC at least to actually do
> > this. Should be easy to catch someone who can bless it and fixing somebody
> 
> Who? You wrote in comment 0 that you weren't available any longer...

Someone like me (I probably would have even still been around on IRC at that time), Neil, Standard8 - or even roc - should be around on IRC.

> NB: I'm so used to get all the blame for warning and fixing things when bustage
> author gets none :-(

(In reply to comment #10)
> When I build xulrunner or firefox, liblayers.so does not exist as a shared
> library.

They do not build shared builds by default, if you build --enable-shared, you get it. We need to do shared builds as we can't support libxul builds right now and static builds don't succeed/work for tests.

> I suppose liblayers.a is generated and it is combined to libxul.so for
> xulrunner/firefox.

Right. It's just due to the different linking.

> Does bug 543159 fix this?

No, and apart from that, we're not even ready to unsupport static build packages, let alone shared ones.
You need to log in before you can comment on or make changes to this bug.