549442 - Incorrect IMAP strings causing crashes on SeaMonkey and Thunderbird when checking mail

Status: VERIFIED FIXED

(Mozilla Localizations :: gl / Galician, defect)

Description

[Mark Banner (:standard8)]

I was doing some testing today and randomly picked Galician as the build to test in.

I left it to idle for a moment and Thunderbird crashed. I did some investigations and found that the crash was already reported in bug 506669. Digging deeper I've found an issue with the string in the Galician locale.

In imapMsgs.properties, there are these two strings in en-US:

## @name IMAP_RECEIVING_MESSAGE_HEADERS_OF
## @loc None
# LOCALIZATION NOTE (Error 5036): Do not translate the word "%S" or "%lu" below.
# Place the word %S in your translation where the name of the server should appear.
# Place the word %lu where the number of headers should appear.
5036=%S Downloading message header %lu of %lu

## @name IMAP_RECEIVING_MESSAGE_FLAGS_OF
## @loc None
# LOCALIZATION NOTE (Error 5037): Do not translate the word "%S" or "%lu" below.
# Place the word %S in your translation where the name of the server should appear.
# Place the word %lu where the number of flags should appear.
5037=%S Downloading message flag %lu of %lu


In Galician they appear as:

5036=Descargando %lu de %lu cabeceiras de mensaxes de %S
5037=Descargando %lu de %lu marcas de mensaxes de %S

The issue here is the code doesn't know which order the arguments are in and tries to print a string to a number - which obviously doesn't work.

I think the correct fix would be changing them to something like:

5036=Descargando %2$lu de %2$lu cabeceiras de mensaxes de %1$S
5037=Descargando %2$lu de %2$lu marcas de mensaxes de %1$S

I've tested this in Thunderbird and it doesn't crash, and other locales do it this way as well.

Attachment 429594 [details] [diff] has revised comments for the strings if you need an explanation of the values.

Comment 1

[Robert Kaiser]

(In reply to comment #0)
> I think the correct fix would be changing them to something like:
> 
> 5036=Descargando %2$lu de %2$lu cabeceiras de mensaxes de %1$S
> 5037=Descargando %2$lu de %2$lu marcas de mensaxes de %1$S

Two times %2$lu? Not %2$lu and %3$lu?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> (In reply to comment #0)
> > I think the correct fix would be changing them to something like:
> > 
> > 5036=Descargando %2$lu de %2$lu cabeceiras de mensaxes de %1$S
> > 5037=Descargando %2$lu de %2$lu marcas de mensaxes de %1$S
> 
> Two times %2$lu? Not %2$lu and %3$lu?

Sorry, that was a typo on my part. To clarify, I'd expect them something like:

5036=Descargando %2$lu de %3$lu cabeceiras de mensaxes de %1$S
5037=Descargando %2$lu de %3$lu marcas de mensaxes de %1$S

Comment 3

[Suso Baleato]

This can ben an alternative if that doesn't work:

http://foros.g11n.net/viewtopic.php?f=20&t=46#p270

I was trying to update the repo with that, but I found some inconsistency and access problems, pending to be solved. 

It will be nice if you can commit the patch to the repo; just please notify me in order to inform the galician community about the availability of the updated binary.

Thanks,

Comment 4

[Simon Paquet [:sipaq]]

(In reply to comment #3)
> This can ben an alternative if that doesn't work:
> 
> http://foros.g11n.net/viewtopic.php?f=20&t=46#p270
> 
> I was trying to update the repo with that, but I found some inconsistency and
> access problems, pending to be solved. 
> 
> It will be nice if you can commit the patch to the repo; just please notify 
> me in order to inform the galician community about the availability of the 
> updated binary.

Suso, 
somehow I'm not able to get to the page mentioned above to access the patch.
Can you send me the patch via mail and I'll commit it for you.

Comment 5

[Simon Paquet [:sipaq]]

Mark, the patch looks alright to me. Can you commit it, please? I'm having problems accessing the l10n-mozilla-1.9.1/gl repository.

Comment 6

[Mark Banner (:standard8)]

Attachment: The fix

This is the patch I'm trying to get pushed into the gl repository. Includes the comment updates from bug 506669.

Comment 7

[Philippe M. Chiasson (:gozer)]

changeset:   377:16fcb3cb1ab0
tag:         tip
parent:      302:1497d90bdec2
user:        Philippe M. Chiasson <[e-mail]>
date:        Mon Mar 15 12:10:19 2010 -0400
summary:     Bug 549442 -  Incorrect IMAP strings causing crashes on SeaMonkey and Thunderbird when checking mail. p=Standard8

Comment 8

[Mark Banner (:standard8)]

Here's the actual revision we checked in:

http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/gl/rev/16fcb3cb1ab0

We're currently seeing if we can regenerate the Thunderbird 'gl' nightlies, but in any case, it would be good to get testing of this from tomorrow's builds.

Comment 9

[Robert Kaiser]

Thanks, I updated the SeaMonkey 2.0.x signoffs to that new revision.

Comment 10

[Mark Banner (:standard8)]

The Thunderbird nightlies have now been built and are available here:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-1.9.1-l10n/

I've been using the mac one successfully for a hour or so now without any issues.

If anyone else can test that would be good as well, just to make sure we've got this fully fixed.

Comment 11

[Suso Baleato]

ACK for Linux. Thanks for the fix.

Comment 12

[Mark Banner (:standard8)]

Suso: Thunderbird 3.0.4 and SeaMonkey 2.0.4 are now released, can you spread the word in the Galician community that this is now fixed and available?

Thunderbird 3.0.4 announcement is here: http://bit.ly/tb304

Comment 13

[Suso Baleato]

Mark, a windows user reported that tb 3.0.4 is still crashing with IMAP while other localizations works ok.

Comment 14

[Ludovic Hirlimann [:Usul]]

(In reply to comment #13)
> Mark, a windows user reported that tb 3.0.4 is still crashing with IMAP while
> other localizations works ok.

Can you get a crashid from that crash. 3.0.4 fixed it for me when I tried the gl locale.