5495 - [DOGFOOD] Can't use text selection to scroll in textarea

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P1)

Description

[cpratt]

build id: 1999042608
reproduces on mac only. works as expected on windows and linux.

to reproduce this, load the url above (or use any page that contains a textarea
with more text in it than can be displayed on screen). click and drag inside the
textarea, moving the mouse down to scroll down and read all of the text in the
textarea. result: you can't - it just highlights down to the last visible line
in the textarea.

expected result: as you continue to drag the mouse down, the text in the
textarea should highlight and scroll down until you reach the end of the text.

Comment 1

[Eli Goldberg]

Drag-selection also doesn't work for web pages, either.

The funny part is that this is the bug example used for the bug writing
guidelines themselves, but I can't find a single actual bug documenting this
issue. ;) I'll go write one.

Comment 2

[Eli Goldberg]

[actually, Simon says that the drag-selection not working on web pages --- as
opposed to textareas --- is a known issue and will be implemented in Msometime,
so I won't write up a bug afterall. ;-]

Comment 3

[mjudge]

yes someday .. someeday...

Comment 4

[mjudge]

this will not be mac specific and I want to use this to track webshells
reluctance to scroll with selection

Comment 5

[Claudius Gayle]

so when you say webshell you mean that drag-selecting on a web won't cause the window to scroll? Do we need a seperate bug
then for the text-area selection not initiating a scroll or will we get that for free when webshell starts behaving?

Changed platform to ALL

Comment 6

[mjudge]

this will require extensive scroll work. i think this will not happen until troy
gets back in about 2 weeks so i am moving this to m9

Comment 7

[leger]

Per a request from Selection and Search component eng (mjudge) and qa (elig),
moving all "Selection and Search" bugs to new "Selection" component.  Original
"Selection and Search" component will be retired.

Comment 8

[Eli Goldberg]

[QA Assigning to self.]

Comment 9

[buster]

Kin, is this part of the scrollFrameToView work you are doing?

Comment 10

[kinmoz]

I am currently working on a couple of methods ScrollRangeIntoView() and
ScrollRectIntoView() that can be used to fix these problems.

After I get these done, I'll work on handling the events that cause
auto-scrolling.

Comment 11

[mjudge]

kin has solution for this he will check in in m12

Comment 12

[kinmoz]

Accepting bug. Cc [e-mail].

Comment 13

[kinmoz]

Setting milestone to M12.

Comment 14

[kinmoz]

Fix checked in:

    layout/base/public/nsIFrame.h  revision 3.129
        - Added GetContentAndOffsetsFromPoint() method. This
          method will eventually replace GetPosition().

    layout/base/public/nsIFrameSelection.h  revision 1.18
        - Added HandleDrag() and Start/StopAutoScrollTimer() methods.

    layout/base/src/nsRangeList.cpp  revision 1.145
        - Added implementation for HandleDrag() and
          Start/StopAutoScrollTimer() methods.

    layout/html/base/src/nsBRFrame.cpp  revision 1.21
        - Added implementation for GetContentAndOffsetsFromPoint().

    layout/html/base/src/nsFrame.cpp  revision 3.157
    layout/html/base/src/nsFrame.h    revision 3.89
        - Added implementation for GetContentAndOffsetsFromPoint().
        - Added GetClosestViewForFrame() utility method.
        - Modified HandleEvent() to call HandleRelease() which now
          stops the auto scrolling timers.
        - Modified HandleDrag() to call nsIFrameSelection's HandleDrag()
          and Start/StopAutoScrollTimer() methods.

    layout/html/base/src/nsTextFrame.cpp  revision 1.176
        - Added implementation for GetContentAndOffsetsFromPoint().

Comment 15

[Eli Goldberg]

Verified on:
	1999100708 Mac OS 8.6 & Linux (RH 6.0/GNOME)
	1999100708 Windows NT 4.0 SP5

Note that the drag-selection highlighting issue from bug #15384 occurs when
reproducing this bug. To be sure, I've left a note in that bug report to double-
check this one when it gets verified.

Comment 16

[Eli Goldberg]

Test case wasn't preserved by bug reporter, so the side-issue can't be verified
as part of verifying bug #15384.

Comment 17

[cpratt]

Attachment: original test case

Comment 18

[Eli Goldberg]

Thanks. Re-verified fixed on this morning's Mac OS & Linux builds.